Conversation
The committers listed above are authorized under a signed CLA. |
|
@philo-micas @madhupalu please help review |
|
|
||
| leaf idkey { | ||
| type uint8 { | ||
| range "1..255"; |
There was a problem hiding this comment.
should we add description for these leaf entries?
There was a problem hiding this comment.
The terms used are simple and look to be self explanatory, hence did not add any description.
| } | ||
| } | ||
|
|
||
| leaf pre_empt { |
There was a problem hiding this comment.
Is there a specific reason to name like pre_empt instead of preempt?
| @@ -0,0 +1,283 @@ | |||
| module sonic-vrrp { | |||
| namespace "http://github.com/Azure/sonic-vrrp"; | |||
| @@ -0,0 +1,283 @@ | |||
| module sonic-vrrp { | |||
There was a problem hiding this comment.
Could you please add unit test and update doc/Configuration.md?
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @vvbrcm , could you help fix build and add test case to this YANG? |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| path "/spc:sonic-portchannel/spc:PORTCHANNEL/spc:PORTCHANNEL_LIST/spc:name"; | ||
| } | ||
| type leafref { | ||
| path "/svlan:sonic-vlan/svlan:VLAN/svlan:VLAN_LIST/svlan:name"; |
There was a problem hiding this comment.
this has to be comment out due to back link in yang issue.
please check sample:
https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-vxlan.yang#L84-L86
| type leafref { | ||
| path "/spc:sonic-portchannel-interface/spc:PORTCHANNEL_INTERFACE/spc:PORTCHANNEL_INTERFACE_LIST/spc:name"; | ||
| } | ||
| type leafref { |
| path "/spc:sonic-portchannel/spc:PORTCHANNEL/spc:PORTCHANNEL_LIST/spc:name"; | ||
| } | ||
| type leafref { | ||
| path "/svlan:sonic-vlan/svlan:VLAN/svlan:VLAN_LIST/svlan:name"; |
| type string { | ||
| pattern 'True|False'; | ||
| } | ||
| } |
There was a problem hiding this comment.
use_v2_checksum is defined in yang model but not supported on cli or in frrcfgd.py. Should this be retained?
8 participants
Why I did it
Added vrrp sonic yang to help configure vrrp module.
Work item tracking
How I did it
Create new sonic-vrrp.yang file.
How to verify it
Unit testing.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)