[DASH] Add Yang definitions for DASH #13078
Conversation
|
Hi, do you intend to eventually provide test files which can be used by a gNMI client to sent to the northbound gNMI interface (for example, any number of CLI-type gNMI clients, or a library)? The .json files appear to be formatted for Redis DB importing. |
| } /* end of list DASH_ROUTE_TABLE_LIST */ | ||
| } /* end of container DASH_ROUTE_TABLE */ | ||
|
|
||
| container DASH_VNET_MAPPING_TABLE { |
There was a problem hiding this comment.
When GNMI run yang validation, GNMI needs to read current config from ApplDB and merge with incoming config.
DASH_ROUTE_TABLE and DASH_VNET_MAPPING_TABLE have large number of entries, so it will spend too much time to read these 2 tables.
My suggestion is to ignore existing DASH_ROUTE_TABLE and DASH_VNET_MAPPING_TABLE in ApplDB, therefore we should use different name pattern for DASH_ROUTE_TABLE and DASH_VNET_MAPPING_TABLE, and then GNMI can ignore these 2 tables and only read other tables. For example, DASHI_ROUTE_TABLE and DASHI_VNET_MAPPING_TABLE
There was a problem hiding this comment.
I don't think gnmi should be reading current config from APPDB for Mapping and Routing. Lets discuss to understand your concern.
There was a problem hiding this comment.
Maybe I can use redis api like redis.keys("DASH_") to read all the other DASH tables except Mapping and Routing, and then Mapping and Routing table should use different name pattern.
Please let me know what you think.
@chrispsommers, i'll work with @ganglyu to provide example gnmi configuration (may not be full-fledged test files) to DASH repo. |
ganglyu
left a comment
There was a problem hiding this comment.
Still need to discuss DASH yang models.
|
Hi @prsunny |
Why I did it
Introduce Sonic Yang for DASH for the following tables:
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)