Revert "Revert suppress FIB pending feature"#19836
Merged
StormLiangMS merged 2 commits intosonic-net:masterfrom Sep 2, 2024
Merged
Revert "Revert suppress FIB pending feature"#19836StormLiangMS merged 2 commits intosonic-net:masterfrom
StormLiangMS merged 2 commits intosonic-net:masterfrom
Conversation
This reverts commit 4397a85.
dgsudharsan
requested review from
StormLiangMS,
lguohan and
qiluo-msft
as code owners
Collaborator
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azpw ms_conflict |
Contributor
|
hi @lipxu could you help to take a look? Or suggest which test we should have nVidia to run to take in this PR? |
Collaborator
Author
Hi @StormLiangMS . We have run the entire sonic-mgmt test suite with these changes + zebra bgp enhancements. We found no issues. We also find memory doesn't increase with test_stress_route with 50 iterations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #19027
The support for BGP zebra enhancements is merged in #19717. Hence re-enabling BGP suppress fib pending feature.