Skip to content

Revert suppress FIB pending feature#19027

Merged
StormLiangMS merged 2 commits intosonic-net:masterfrom
stepanblyschak:revert-suppress-fib
Jul 12, 2024
Merged

Revert suppress FIB pending feature#19027
StormLiangMS merged 2 commits intosonic-net:masterfrom
stepanblyschak:revert-suppress-fib

Conversation

@stepanblyschak
Copy link
Collaborator

@stepanblyschak stepanblyschak commented May 21, 2024

Why I did it

Revert BGP suppress FIB pending due to unresolved FRR issues in current version

Work item tracking
  • Microsoft ADO (number only):

How I did it

Revert it

How to verify it

Build and run

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202405

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

By default SONiC advertises /128 subnet prefix in Loopback0 as /64 subnet route";
}

leaf suppress-fib-pending {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i suggest to keep these yang model instead of simple reverting.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lguohan I don't want to keep CLI and YANG model for a feature that does not work in a release

@stepanblyschak stepanblyschak marked this pull request as ready for review May 23, 2024 15:41
@stepanblyschak
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@stepanblyschak
Copy link
Collaborator Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

@lguohan how do you want to followup on that?

@StormLiangMS
Copy link
Contributor

/azpw ms_conflict

@stepanblyschak
Copy link
Collaborator Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liushilongbuaa
Copy link
Contributor

/azpw ms_conflict -f

@liushilongbuaa
Copy link
Contributor

/azpw ms_conflict

Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 4397a85 into sonic-net:master Jul 12, 2024
@StormLiangMS
Copy link
Contributor

hi @stepanblyschak I think we also need this for 202405, could you help to run a test before we do the cherry pick for 202405? @bingwang-ms for vis.

@stepanblyschak
Copy link
Collaborator Author

@StormLiangMS This PR was targeting 202405 originally

@dgsudharsan
Copy link
Collaborator

@bingwang-ms Please cherry-pick this PR for 202405

@dgsudharsan
Copy link
Collaborator

@bingwang-ms Can you please check why PR for 202405 is not created?

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jul 30, 2024
Why I did it
Revert BGP suppress FIB pending due to unresolved FRR issues in current version

Work item tracking
Microsoft ADO (number only):
How I did it
Revert it

How to verify it
Build and run
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #19736

@liushilongbuaa
Copy link
Contributor

@bingwang-ms Can you please check why PR for 202405 is not created?

I checked the logs. But I don't find the reason.

mssonicbld pushed a commit that referenced this pull request Jul 30, 2024
Why I did it
Revert BGP suppress FIB pending due to unresolved FRR issues in current version

Work item tracking
Microsoft ADO (number only):
How I did it
Revert it

How to verify it
Build and run
dgsudharsan added a commit to dgsudharsan/sonic-buildimage that referenced this pull request Aug 6, 2024
StormLiangMS pushed a commit that referenced this pull request Sep 2, 2024
Reverts #19027

The support for BGP zebra enhancements is merged in #19717. Hence re-enabling BGP suppress fib pending feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants