[build] Use DEFAULT_CONTAINER_REGISTRY in Makefile.work instead of dockerhub. (#19445)#19598
Merged
StormLiangMS merged 1 commit intosonic-net:202305from Jul 18, 2024
Merged
Conversation
Why I did it DEFAULT_CONTAINER_REGISTRY didn't work as expected in some scenario. How I did it When check for docker arch, use DEFAULT_CONTAINER_REGISTRY if it is not null.
liushilongbuaa
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
liushilongbuaa
changed the title
Contributor
|
FYI: We also pull from dockerhub here: |
Contributor
Author
dockerhub has a request limit. Reducing pull request in Makefile will make swss pull request success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
DEFAULT_CONTAINER_REGISTRY didn't work as expected in some scenario.
Work item tracking
How I did it
When check for docker arch, use DEFAULT_CONTAINER_REGISTRY if it is not null.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)