Skip to content

Commit 553ae45

Browse files
fix (#19445) (#19598)
Why I did it DEFAULT_CONTAINER_REGISTRY didn't work as expected in some scenario. How I did it When check for docker arch, use DEFAULT_CONTAINER_REGISTRY if it is not null.
1 parent de6e208 commit 553ae45

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

Makefile.work

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,11 @@ SHELL = /bin/bash
7171
USER := $(shell id -un)
7272
PWD := $(shell pwd)
7373
USER_LC := $(shell echo $(USER) | tr A-Z a-z)
74+
ifneq ($(DEFAULT_CONTAINER_REGISTRY),)
75+
DOCKER_MACHINE := $(shell docker run --rm $(DEFAULT_CONTAINER_REGISTRY)/debian:buster uname -m)
76+
else
7477
DOCKER_MACHINE := $(shell docker run --rm debian:buster uname -m)
78+
endif
7579

7680
comma := ,
7781

@@ -282,7 +286,7 @@ endif
282286
DOCKER_LOCKFILE_SAVE := $(DOCKER_LOCKDIR)/docker_save.lock
283287
$(shell mkdir -m 0777 -p $(DOCKER_LOCKDIR))
284288
$(shell [ -f $(DOCKER_LOCKFILE_SAVE) ] || (touch $(DOCKER_LOCKFILE_SAVE) && chmod 0777 $(DOCKER_LOCKFILE_SAVE)))
285-
$(shell [ -d $(DOCKER_ROOT) ] && docker run --rm -v $(DOCKER_ROOT)\:/mount debian sh -c 'rm -rf /mount/*')
289+
$(shell [ -d $(DOCKER_ROOT) ] && docker run --rm -v $(DOCKER_ROOT)\:/mount $(DEFAULT_CONTAINER_REGISTRY)debian sh -c 'rm -rf /mount/*')
286290
$(mkdir -p $(DOCKER_ROOT))
287291

288292
ifeq ($(DOCKER_BUILDER_MOUNT),)
@@ -401,7 +405,7 @@ endif
401405
#Override Native config to prevent docker service
402406
SONIC_CONFIG_USE_NATIVE_DOCKERD_FOR_BUILD=y
403407

404-
DOCKER_MULTIARCH_CHECK := docker run --rm --privileged multiarch/qemu-user-static --reset -p yes --credential yes
408+
DOCKER_MULTIARCH_CHECK := docker run --rm --privileged $(DEFAULT_CONTAINER_REGISTRY)multiarch/qemu-user-static --reset -p yes --credential yes
405409

406410
DOCKER_SERVICE_SAFE_KILLER := (MARCH_PID=`ps -eo pid,cmd | grep "[0-9] dockerd.*march" | awk '{print $$1}'`; echo "Killing march docker $$MARCH_PID"; [ -z "$$MARCH_PID" ] || sudo kill -9 "$$MARCH_PID";)
407411
DOCKER_SERVICE_MULTIARCH_CHECK := ($(DOCKER_SERVICE_SAFE_KILLER); sudo rm -fr /var/run/march/; (echo "Starting docker march service..."; sudo $(SONIC_NATIVE_DOCKERD_FOR_MULTIARCH) &) &>/dev/null ; sleep 2; sudo $(SONIC_USERFACL_DOCKERD_FOR_MULTIARCH);)

0 commit comments

Comments
 (0)