Add a function to get the container name for a service according to the ASIC ID#18459
Merged
liat-grozovik merged 2 commits intosonic-net:masterfrom Apr 15, 2024
Merged
Conversation
Junchao-Mellanox
changed the title
Junchao-Mellanox
force-pushed
the
master-get-service-name
branch
from
6ad3b72 to
a167455
Compare
Junchao-Mellanox
force-pushed
the
master-get-service-name
branch
from
a167455 to
691a78f
Compare
keboliu
approved these changes
Apr 1, 2024
saiarcot895
approved these changes
Apr 3, 2024
liat-grozovik
changed the title
Collaborator
|
@Junchao-Mellanox please handle conflict so merge can take place |
Collaborator
Author
Done |
liat-grozovik
approved these changes
Apr 15, 2024
Collaborator
|
@Junchao-Mellanox the description has no reference to 202311. is it required? if not, all good. |
Collaborator
Author
|
Hi @yxieca , could you please help cherry-pick to 202311? |
Collaborator
Author
|
Will create separate PR |
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-buildimage
that referenced
this pull request
Apr 15, 2024
- Why I did it Get the container name for a service according to the ASIC ID - How I did it Add new function to get the requested data - How to verify it Add unit test to cover the new added function
11 tasks
Collaborator
Author
|
Cherry pick PR: #18682 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Get the container name for a service according to the ASIC ID
Work item tracking
How I did it
Add new function to get the requested data
How to verify it
Add unit test to cover the new added function
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)