[202311] Add multi ASIC support for syslog rate limit feature#3275
Closed
Junchao-Mellanox wants to merge 1 commit intosonic-net:202311from
Closed
[202311] Add multi ASIC support for syslog rate limit feature#3275Junchao-Mellanox wants to merge 1 commit intosonic-net:202311from
Junchao-Mellanox wants to merge 1 commit intosonic-net:202311from
Conversation
* Add multi ASIC support for syslog rate limit feature * Update command ref
Contributor
|
@Junchao-Mellanox we should not back port feature to 202311. This feature will be picked up by 202405 branch. |
Collaborator
Hi @yxieca in the 202311 branch, the syslog rate limit feature has an issue supporting multi ASIC scenarios, these set of PRs is to fix the issue, I suggest to cherry-pick 202311, but it's your call. |
Collaborator
Author
|
Close as we are not going to take this to 202311 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport PR to 202311: #3235
Build dependency: sonic-net/sonic-buildimage#18682
What I did
Add multi ASIC support for syslog rate limit feature
How I did it
show syslog rate-limit-containeradd a new option namespaceconfig syslog rate-limit-containeradd a new option namespaceconfig syslog rate-limit-featureenable add a new option namespace and a new argument service_nameconfig syslog rate-limit-featuredisable add a new option namespace and a new argument service_nameHow to verify it
Manual test
Previous command output (if the output of a command-line utility has changed)
show syslog rate-limit-container help:
config syslog rate-limit-container help
config syslog rate-limit-feature enable help
config syslog rate-limit-feature disable help
New command output (if the output of a command-line utility has changed)
show syslog rate-limit-container help:
[new] show all config in multi ASIC platforms:
[new] show global namespace configuration:
[new] show configuration for a given namespace:
config syslog rate-limit-container help:
sudo config syslog rate-limit-feature enable help
sudo config syslog rate-limit-feature disable help