Skip to content

Tag the newly built docker as remote latest and push to the remote registry#1742

Closed
wendani wants to merge 1 commit intosonic-net:masterfrom
wendani:docker_tag
Closed

Tag the newly built docker as remote latest and push to the remote registry#1742
wendani wants to merge 1 commit intosonic-net:masterfrom
wendani:docker_tag

Conversation

@wendani
Copy link
Contributor

@wendani wendani commented May 25, 2018

Signed-off-by: Wenda

- What I did
Tag latest is not updated with images push to the remote registry. This causes the ptf host to always perceive its local ptf docker image, if present, to be up to date when creating the ptf docker container.

To address this, add tag remote latest to the docker image and push to the remote registry to update

- How I did it

Change push_docker.sh

- How to verify it
Not fully, but manually tried

docker image tag <remote/image>:latest
docker image push <remote/image>:latest
docker image pull <remote/image>

on ptf host against internal registry. It updates the tag latest on remote registry.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@wendani wendani requested review from lguohan, qiluo-msft and yxieca May 25, 2018 05:16
@qiluo-msft
Copy link
Collaborator

DOCKER_IMAGE_TAG=$6

Actually, the feature is already supported by calling:

./push_docker.sh DOCKER_IMAGE_FILE REGISTRY_SERVER REGISTRY_PORT REGISTRY_USERNAME REGISTRY_PASSWD latest

without any code change.


Refers to: push_docker.sh:6 in 3ed7ed5. [](commit_id = 3ed7ed5, deletion_comment = False)

Copy link
Collaborator

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block the code change, see comment.

@wendani wendani closed this May 25, 2018
richardyu-ms added a commit to richardyu-ms/sonic-buildimage that referenced this pull request Feb 9, 2023
include sairedis changes
3a960be | [submodule][SAI]ADvance SAI Header (sonic-net#1206)
7026441 | [Mellanox] Enable DSCP remapping by using SAI attribute (sonic-net#1188)
a2c37b8 | [syncd]: Enable port bulk API (sonic-net#1197)

include SAI changes
7710e24 | [cherry-pick][202211]Enhance the check enum lock script (sonic-net#1741) (sonic-net#1742)
0031470 | improve enum values integration check (sonic-net#1727) (sonic-net#1737)
4f11c7e | Enable github code scanning to replace LGTM. (sonic-net#1709)
0fd23d2 | [SAI-PTF] Skip test when hit expected error from sai api (sonic-net#1699)
aba7612 | [SAI-PTF] API Logger - reformat arg values (sonic-net#1696)
1390cee | [SAI-PTF] API Logger - reformat dict in return value (sonic-net#1690)
3d96a1d | [SAI-PTF]Add return value in the SAI-PTF log (sonic-net#1685)

Signed-off-by: richardyu-ms <[email protected]>
xumia pushed a commit that referenced this pull request Feb 11, 2023
include sairedis changes
3a960be | [submodule][SAI]ADvance SAI Header (#1206)
7026441 | [Mellanox] Enable DSCP remapping by using SAI attribute (#1188)
a2c37b8 | [syncd]: Enable port bulk API (#1197)

include SAI changes
7710e24 | [cherry-pick][202211]Enhance the check enum lock script (#1741) (#1742)
0031470 | improve enum values integration check (#1727) (#1737)
4f11c7e | Enable github code scanning to replace LGTM. (#1709)
0fd23d2 | [SAI-PTF] Skip test when hit expected error from sai api (#1699)
aba7612 | [SAI-PTF] API Logger - reformat arg values (#1696)
1390cee | [SAI-PTF] API Logger - reformat dict in return value (#1690)
3d96a1d | [SAI-PTF]Add return value in the SAI-PTF log (#1685)

Signed-off-by: richardyu-ms <[email protected]>
xumia pushed a commit that referenced this pull request Feb 12, 2023
Why I did it
include changes from sairedis submodule
102d20b | [202211][submodule][SAI]Advance header include 0031470 | improve enum values integration check (#1727) (#1737)
04d3c41 | [Submodule][upgrade]Upgrade SAI submodule (#1204)

updates from SAI
7710e24 | [cherry-pick][202211]Enhance the check enum lock script (#1741) (#1742)
0031470 | improve enum values integration check (#1727) (#1737)
4f11c7e | Enable github code scanning to replace LGTM. (#1709)

How I did it
How to verify it
StormLiangMS pushed a commit to StormLiangMS/sonic-buildimage that referenced this pull request Mar 28, 2023
Related work items: sonic-net#276, sonic-net#305, sonic-net#332, sonic-net#338, sonic-net#339, sonic-net#1188, sonic-net#1192, sonic-net#1197, sonic-net#1206, sonic-net#1685, sonic-net#1690, sonic-net#1696, sonic-net#1699, sonic-net#1709, sonic-net#1727, sonic-net#1737, sonic-net#1741, sonic-net#1742, sonic-net#2511, sonic-net#2512, sonic-net#2532, sonic-net#2559, sonic-net#2626, sonic-net#2638, sonic-net#2645, sonic-net#2649, sonic-net#2660, sonic-net#2669, sonic-net#2670, sonic-net#2678, sonic-net#10084, sonic-net#11442, sonic-net#11873, sonic-net#12047, sonic-net#12110, sonic-net#12207, sonic-net#12529, sonic-net#12678, sonic-net#13235, sonic-net#13287, sonic-net#13372, sonic-net#13395, sonic-net#13456, sonic-net#13497, sonic-net#13522, sonic-net#13545, sonic-net#13547, sonic-net#13552, sonic-net#13569, sonic-net#13572, sonic-net#13578, sonic-net#13591, sonic-net#13611, sonic-net#13647, sonic-net#13649, sonic-net#13660, sonic-net#13710, sonic-net#13716, sonic-net#13724, sonic-net#13726, sonic-net#13732, sonic-net#13735, sonic-net#13739, sonic-net#13757, sonic-net#13786, sonic-net#13792, sonic-net#13800, sonic-net#13801, sonic-net#13802, sonic-net#13805, sonic-net#13806, sonic-net#13812, sonic-net#13814, sonic-net#13822, sonic-net#13831, sonic-net#13834, sonic-net#13847, sonic-net#13870, sonic-net#13882, sonic-net#13884, sonic-net#13885, sonic-net#13894, sonic-net#13895, sonic-net#13926, sonic-net#13932, sonic-net#13935, sonic-net#13942, sonic-net#13951, sonic-net#13953, sonic-net#13964
noaOrMlnx pushed a commit to noaOrMlnx/sonic-buildimage that referenced this pull request Nov 24, 2025
…D automatically (sonic-net#1742)

#### Why I did it
src/sonic-sairedis
```
* 8dd9c77d - (HEAD -> 202412, origin/HEAD, origin/202412) Merge pull request sonic-net#94 from mssonicbld/sonicbld/202412-merge (23 hours ago) [mssonicbld]
* 52ee61c4 - Merge branch '202411' of https://github.com/sonic-net/sonic-sairedis into 202412 (23 hours ago) [Sonic Automation]
* 92fcd342 - [meta] do not fail bulk operations if MODE_IGNORE_ERROR (sonic-net#1666) (28 hours ago) [Nikola Dancejic]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Jan 31, 2026
…tically (#25251)

#### Why I did it
src/sonic-sairedis
```
* 8c3d40d5 - (HEAD -> master, origin/master, origin/HEAD) Add PORT_PHY_ATTR flex counter support (#1674) (9 hours ago) [Dhanasekar Rathinavel]
* 5966a71b - Update SAI Header to latest (#1742) (2 days ago) [Tejaswini Chadaga]
* 2752ad6c - [multi-asic][Mellanox] add support for Mellanox multi-asic (#1683) (3 days ago) [Yakiv Huryk]
* c4e3c142 - Fix deadlock between syncd and orchagent syncd during initialization failure (#1723) (7 days ago) [DavidZagury]
* 50c5626c - Fix dash meter COUNTERS_DB keys to use VID instead of RID (#1725) (8 days ago) [Mukesh Moopath Velayudhan]
* 7632eebb - [Mellanox] Add phcsync activation for mellanox platforms. (#1734) (9 days ago) [‪Zili Bombach‬‏]
* 9eeffe38 - fix docker slave name (#1730) (10 days ago) [yijingyan2]
* 90670166 - Use matching slave container from the branch we're building against (#1743) (10 days ago) [Saikrishna Arcot]
```
#### How I did it
#### How to verify it
#### Description for the changelog
xincunli-sonic pushed a commit to xincunli-sonic/sonic-buildimage that referenced this pull request Feb 2, 2026
…tically (sonic-net#25251)

#### Why I did it
src/sonic-sairedis
```
* 8c3d40d5 - (HEAD -> master, origin/master, origin/HEAD) Add PORT_PHY_ATTR flex counter support (sonic-net#1674) (9 hours ago) [Dhanasekar Rathinavel]
* 5966a71b - Update SAI Header to latest (sonic-net#1742) (2 days ago) [Tejaswini Chadaga]
* 2752ad6c - [multi-asic][Mellanox] add support for Mellanox multi-asic (sonic-net#1683) (3 days ago) [Yakiv Huryk]
* c4e3c142 - Fix deadlock between syncd and orchagent syncd during initialization failure (sonic-net#1723) (7 days ago) [DavidZagury]
* 50c5626c - Fix dash meter COUNTERS_DB keys to use VID instead of RID (sonic-net#1725) (8 days ago) [Mukesh Moopath Velayudhan]
* 7632eebb - [Mellanox] Add phcsync activation for mellanox platforms. (sonic-net#1734) (9 days ago) [‪Zili Bombach‬‏]
* 9eeffe38 - fix docker slave name (sonic-net#1730) (10 days ago) [yijingyan2]
* 90670166 - Use matching slave container from the branch we're building against (sonic-net#1743) (10 days ago) [Saikrishna Arcot]
```
#### How I did it
#### How to verify it
#### Description for the changelog

Signed-off-by: Xincun Li <[email protected]>
FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Mar 6, 2026
…tically (sonic-net#25251)

#### Why I did it
src/sonic-sairedis
```
* 8c3d40d5 - (HEAD -> master, origin/master, origin/HEAD) Add PORT_PHY_ATTR flex counter support (sonic-net#1674) (9 hours ago) [Dhanasekar Rathinavel]
* 5966a71b - Update SAI Header to latest (sonic-net#1742) (2 days ago) [Tejaswini Chadaga]
* 2752ad6c - [multi-asic][Mellanox] add support for Mellanox multi-asic (sonic-net#1683) (3 days ago) [Yakiv Huryk]
* c4e3c142 - Fix deadlock between syncd and orchagent syncd during initialization failure (sonic-net#1723) (7 days ago) [DavidZagury]
* 50c5626c - Fix dash meter COUNTERS_DB keys to use VID instead of RID (sonic-net#1725) (8 days ago) [Mukesh Moopath Velayudhan]
* 7632eebb - [Mellanox] Add phcsync activation for mellanox platforms. (sonic-net#1734) (9 days ago) [‪Zili Bombach‬‏]
* 9eeffe38 - fix docker slave name (sonic-net#1730) (10 days ago) [yijingyan2]
* 90670166 - Use matching slave container from the branch we're building against (sonic-net#1743) (10 days ago) [Saikrishna Arcot]
```
#### How I did it
#### How to verify it
#### Description for the changelog

Signed-off-by: Feng Pan <[email protected]>
dprital pushed a commit that referenced this pull request Mar 19, 2026
…tically (#25251)

#### Why I did it
src/sonic-sairedis
```
* 8c3d40d5 - (HEAD -> master, origin/master, origin/HEAD) Add PORT_PHY_ATTR flex counter support (#1674) (9 hours ago) [Dhanasekar Rathinavel]
* 5966a71b - Update SAI Header to latest (#1742) (2 days ago) [Tejaswini Chadaga]
* 2752ad6c - [multi-asic][Mellanox] add support for Mellanox multi-asic (#1683) (3 days ago) [Yakiv Huryk]
* c4e3c142 - Fix deadlock between syncd and orchagent syncd during initialization failure (#1723) (7 days ago) [DavidZagury]
* 50c5626c - Fix dash meter COUNTERS_DB keys to use VID instead of RID (#1725) (8 days ago) [Mukesh Moopath Velayudhan]
* 7632eebb - [Mellanox] Add phcsync activation for mellanox platforms. (#1734) (9 days ago) [‪Zili Bombach‬‏]
* 9eeffe38 - fix docker slave name (#1730) (10 days ago) [yijingyan2]
* 90670166 - Use matching slave container from the branch we're building against (#1743) (10 days ago) [Saikrishna Arcot]
```
#### How I did it
#### How to verify it
#### Description for the changelog

Signed-off-by: dprital <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants