[build] add an environment variable to run make reset unattended#12207
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Feb 15, 2023
Merged
[build] add an environment variable to run make reset unattended#12207liat-grozovik merged 1 commit intosonic-net:masterfrom
liat-grozovik merged 1 commit intosonic-net:masterfrom
Conversation
mathieulaunay
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
|
|
mathieulaunay
force-pushed
the
unattended-make-reset
branch
from
b34bee9 to
a45d4c6
Compare
mathieulaunay
force-pushed
the
unattended-make-reset
branch
from
a45d4c6 to
364f80d
Compare
|
@stepanblyschak could you please provide feedback? |
- previously "make reset" was expecting user input from the terminal
to do its job
- setting UNATTENDED to any non-zero string will allow "make reset" to
run without interactive confirmation
mathieulaunay
force-pushed
the
unattended-make-reset
branch
from
364f80d to
28b465c
Compare
stepanblyschak
approved these changes
Jan 25, 2023
|
@qiluo-msft Hi - can you merge please? |
Collaborator
|
@xumia could u please help to review? |
Contributor
Author
|
hi, could you please review & merge this? |
|
@xumia your assistance please. |
xumia
approved these changes
Feb 14, 2023
Collaborator
LGTM, need to make sure if any automation script using it to reset the env, if yes, need to add the UNATTENDED option before merge. |
Contributor
azure pipeline didn't use make reset and cleanup. |
liushilongbuaa
approved these changes
Feb 15, 2023
liat-grozovik
changed the title
Collaborator
|
@mathieulaunay please check if this can be cleanly cherry picked to the desired branches but if not, please have a PR against each branch needed. |
This was referenced Feb 15, 2023
Contributor
Author
|
@liat-grozovik since it cannot be cherry-picked without conflicts, please find:
|
Collaborator
|
@mathieulaunay PR conflicts with 202211 branch |
Collaborator
|
@mathieulaunay PR conflicts with 202205 branch |
liat-grozovik
pushed a commit
that referenced
this pull request
Feb 21, 2023
previously "make reset" was expecting user input from the terminal to do its job setting UNATTENDED to any non-zero string will allow "make reset" to run without interactive confirmation - Why I did it This is the backport to 202211 from master (see PR #12207) When doing automated builds of SONiC images, we need to reset the working repositories between each build. - How I did it Adding an environment variable that is read by Makefile.work - How to verify it running UNATTENDED=1 make reset should make an automatic reset of all working directories
Collaborator
|
There are separated PRs per branch (see above references). |
StormLiangMS
pushed a commit
to StormLiangMS/sonic-buildimage
that referenced
this pull request
Mar 28, 2023
Related work items: sonic-net#276, sonic-net#305, sonic-net#332, sonic-net#338, sonic-net#339, sonic-net#1188, sonic-net#1192, sonic-net#1197, sonic-net#1206, sonic-net#1685, sonic-net#1690, sonic-net#1696, sonic-net#1699, sonic-net#1709, sonic-net#1727, sonic-net#1737, sonic-net#1741, sonic-net#1742, sonic-net#2511, sonic-net#2512, sonic-net#2532, sonic-net#2559, sonic-net#2626, sonic-net#2638, sonic-net#2645, sonic-net#2649, sonic-net#2660, sonic-net#2669, sonic-net#2670, sonic-net#2678, sonic-net#10084, sonic-net#11442, sonic-net#11873, sonic-net#12047, sonic-net#12110, sonic-net#12207, sonic-net#12529, sonic-net#12678, sonic-net#13235, sonic-net#13287, sonic-net#13372, sonic-net#13395, sonic-net#13456, sonic-net#13497, sonic-net#13522, sonic-net#13545, sonic-net#13547, sonic-net#13552, sonic-net#13569, sonic-net#13572, sonic-net#13578, sonic-net#13591, sonic-net#13611, sonic-net#13647, sonic-net#13649, sonic-net#13660, sonic-net#13710, sonic-net#13716, sonic-net#13724, sonic-net#13726, sonic-net#13732, sonic-net#13735, sonic-net#13739, sonic-net#13757, sonic-net#13786, sonic-net#13792, sonic-net#13800, sonic-net#13801, sonic-net#13802, sonic-net#13805, sonic-net#13806, sonic-net#13812, sonic-net#13814, sonic-net#13822, sonic-net#13831, sonic-net#13834, sonic-net#13847, sonic-net#13870, sonic-net#13882, sonic-net#13884, sonic-net#13885, sonic-net#13894, sonic-net#13895, sonic-net#13926, sonic-net#13932, sonic-net#13935, sonic-net#13942, sonic-net#13951, sonic-net#13953, sonic-net#13964
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
When doing automated builds of SONiC images, we need to reset the working repositories between each build.
How I did it
Adding an environment variable that is read by Makefile.work
How to verify it
running
UNATTENDED=1 make resetshould make an automatic reset of all working directories
Which release branch to backport (provide reason below if selected)
Description for the changelog
add an environment variable to run "make reset" unattended
Ensure to add label/tag for the feature raised. example - PR#2174 where, Generic Config and Update feature has been labelled as GCU.
N/A
Link to config_db schema for YANG module changes
N/A
A picture of a cute animal (not mandatory but encouraged)