[lldp] Clean up service start logic owing to port init start optimization#17133
[lldp] Clean up service start logic owing to port init start optimization#17133yxieca merged 1 commit intosonic-net:bookwormfrom
Conversation
…tion Signed-off-by: Vivek Reddy <[email protected]>
| @@ -1 +0,0 @@ | |||
| per_namespace/lldp.timer.j2 No newline at end of file | |||
There was a problem hiding this comment.
Does the actual file need to be deleted as well, not just the symlink?
There was a problem hiding this comment.
Actual file doesn't exist
There was a problem hiding this comment.
The file is here: https://github.com/sonic-net/sonic-buildimage/blob/master/files/build_templates/per_namespace/lldp.service.j2
Removing the symbolic link might break chassis? @arlakshm
There was a problem hiding this comment.
That's the lldp.service file, not the lldp.timer file. It looks like the timer was removed in #13969.
@SuvarnaMeenakshi @abdosi can help check if this change will have impact on chassis bootup? |
|
@SuvarnaMeenakshi @abdosi @yxieca Any update on the review? |
|
I don't see this change impacting multi-asic or chassis apart from the fact that lldp will always start after the delay which was not the case earlier (not due to this PR but due to PR 13969) |
6 participants
Why I did it
As part of service start optimization done, we've removed timer units and used PORT_INIT_DONE as the checkpoint for starting delayed services. Thus this logic is redundant
This fixes the following error log.
How I did it
Redundant lldp timer code is removed from syncd.sh.
How to verify it
Build and test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)