[tacacs] User with priv_lvl 0 should not be in docker group#1626
Merged
taoyl-ms merged 1 commit intosonic-net:masterfrom Apr 21, 2018
Merged
[tacacs] User with priv_lvl 0 should not be in docker group#1626taoyl-ms merged 1 commit intosonic-net:masterfrom
taoyl-ms merged 1 commit intosonic-net:masterfrom
Conversation
jleveque
approved these changes
Apr 20, 2018
lguohan
reviewed
Apr 20, 2018
| + | ||
| + user = &useradd_grp_list[MIN_TACACS_USER_PRIV]; | ||
| + user->gid = 999; | ||
| + user->gid = 100; |
Collaborator
There was a problem hiding this comment.
is 100 conflict with existing groups?
Contributor
Author
There was a problem hiding this comment.
It is a linux built-in group ('user') and I don't think it is used anywhere in sonic.
lguohan
approved these changes
Apr 20, 2018
lguohan
pushed a commit
that referenced
this pull request
Sep 9, 2021
To include sonic_installer swap setup changes 171eb4f [sonic_installer] Add swap setup support (#1787) 6483b0b QOS fieldvalue refernce ABNF format to string (#1626) 8d16eb5 [Fast-reboot] Set flex counters delay indicator to prevent flex counters enablement after fast-reboot (#1768) 1bc24ca [portstat pfcstat] Unify the packet number format in the output of portstat and pfcstat in all cases (#1755) d7900dd [config][generic-update] Implementing patch sorting (2nd attempt) (#1794) 7ed9a91 [show] Allow system with no ports in config db run without errors (#1754) Signed-off-by: Longxiang Lyu <[email protected]>
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
Qos tables in config db and app db used ABNF format i.e "[TABLE_NAME|name] to refer fieldvalue other qos tables.
Example:
Config DB:
"Ethernet92|3": {
"scheduler": "[SCHEDULER|scheduler.1]",
"wred_profile": "[WRED_PROFILE|AZURE_LOSSLESS]"
},
"Ethernet0|0": {
"profile": "[BUFFER_PROFILE|ingress_lossy_profile]"
},
"Ethernet0": {
"dscp_to_tc_map": "[DSCP_TO_TC_MAP|AZURE]",
"pfc_enable": "3,4",
"pfc_to_queue_map": "[MAP_PFC_PRIORITY_TO_QUEUE|AZURE]",
"tc_to_pg_map": "[TC_TO_PRIORITY_GROUP_MAP|AZURE]",
"tc_to_queue_map": "[TC_TO_QUEUE_MAP|AZURE]"
},
AppDB:
"BUFFER_QUEUE_TABLE:Ethernet88:3-4": {
"profile": "[BUFFER_PROFILE_TABLE:egress_lossless_profile]"
},
1#This format is not consistent with other DB schema followed in sonic.
2# Added db_migrator.py case to change from old format in config_db and appl_db to new format.
3#Modified the test case
Dependent pull requests:
sonic-net#7752 - To modify platfrom files
sonic-net#7281 - Yang model
sonic-net/sonic-swss#1754 - swss change to remove ABNF format
patrickmacarthur
pushed a commit
to patrickmacarthur/sonic-buildimage
that referenced
this pull request
Dec 11, 2025
<!--
Please make sure you've read and understood our contributing guidelines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md
** Make sure all your commits include a signature generated with `git
commit -s` **
If this is a bug fix, make sure your description includes "fixes #xxxx",
or
"closes #xxxx" or "resolves #xxxx"
Please provide the following information:
-->
#### Why I did it
To bring in latest sai brcm fixes
##### Work item tracking
- Microsoft ADO **(32398635)**:
#### How I did it
Updated DNX SAI version from 11.2.31.1 => 11.2.36.1
Changes -
updated sai release version to 11.2.34.1
[CSP CS00012405910] backport SONIC-98783 to rel_ocp_sai_11_2:
DNX: Platform init changes to report INIT_DNX and linkscan fw load
errors
updated sai release version to 11.2.35.1
[SAI_BRANCH rel_ocp_sai_11_2] [CSP CS00012396188] Backport JIRA
SONIC-103048 to el_ocp_sai_11_2
JIRA# SONIC-106317
Issue Summary: tc4 cpu traffic was dropped when there is relatively
higher rate of tc0 cpu traffic
Root Cause: RFD
Fix Description: RFD
updated sai release version to 11.2.36.1
[CSP CS00012407282] Set internal flow control (EGQ->SCH) mapping on port
creation
#### How to verify it
<!--
If PR needs to be backported, then the PR must be tested against the
base branch and the earliest backport release branch and provide tested
image version on these two branches. For example, if the PR is requested
for master, 202211 and 202012, then the requester needs to provide test
results on master and 202012.
-->
#### Which release branch to backport (provide reason below if selected)
<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->
- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211
#### Tested branch (Please provide the tested image version)
<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->
- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->
#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->
<!--
Ensure to add label/tag for the feature raised. example - PR#2174 under
sonic-utilities repo. where, Generic Config and Update feature has been
labelled as GCU.
-->
#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->
#### A picture of a cute animal (not mandatory but encouraged)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Current default users with minimal priv_lv are created in docker group (999), which grants them full access within the docker. This commit moves them into users group (100) instead.
- How to verify it
Create a user with priv_lv 0 on TACACS server and use this user account to login onto sonic device. This user should not have full access to dockers.