Merged
Conversation
It appears that this was initially added to provide the git-retry command (which doesn't appear to be used today). However, this repo is now also providing bazel (which is actually used in our build today), and this command (along with git-retry) expects some vpython3 binary to be set up/installed. Rather than going through that, just get rid of this repo. Signed-off-by: Saikrishna Arcot <[email protected]>
qiluo-msft
approved these changes
Aug 12, 2023
liushilongbuaa
approved these changes
Aug 14, 2023
Contributor
liushilongbuaa
left a comment
liushilongbuaa
left a comment
There was a problem hiding this comment.
LGTM.
Root cause is code change in depot_tools repo.
Daily build succeeded because we pined repo HEAD:
Contributor
|
We're still seeing this issue on 202305. Can you please get this double committed? @qiluo-msft @lguohan |
Contributor
|
@saiarcot895 do we have an ADO? |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 3, 2023
It appears that this was initially added to provide the git-retry command (which doesn't appear to be used today). However, this repo is now also providing bazel (which is actually used in our build today), and this command (along with git-retry) expects some vpython3 binary to be set up/installed. Rather than going through that, just get rid of this repo.
Collaborator
|
Cherry-pick PR to 202305: #16408 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Sep 3, 2023
It appears that this was initially added to provide the git-retry command (which doesn't appear to be used today). However, this repo is now also providing bazel (which is actually used in our build today), and this command (along with git-retry) expects some vpython3 binary to be set up/installed. Rather than going through that, just get rid of this repo.
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
Contributor
Author
|
@StormLiangMS Updated PR description with the ADO number, and ADO for backport to 202305 is 25059425. |
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
It appears that this was initially added to provide the git-retry command (which doesn't appear to be used today). However, this repo is now also providing bazel (which is actually used in our build today), and this command (along with git-retry) expects some vpython3 binary to be set up/installed. Rather than going through that, just get rid of this repo.
7 tasks
ec-michael-shih
added a commit
to ec-michael-shih/ec-sonic-buildimage
that referenced
this pull request
Dec 12, 2023
Apply community PR : sonic-net/sonic-buildimage#14293 Detail: sonic-net/sonic-buildimage#14292 as4630-54npe already merge(at commit id: 4be14f0) the PRs below: sonic-net/sonic-buildimage#13241 sonic-net/sonic-buildimage#13288 sonic-net/sonic-buildimage#15002 sonic-net/sonic-buildimage#13685 sonic-net/sonic-buildimage#14475 sonic-net/sonic-buildimage#14993 sonic-net/sonic-buildimage#14919 sonic-net/sonic-buildimage#15461 sonic-net/sonic-buildimage#16114 sonic-net/sonic-buildimage#334
7 tasks
fengkm
pushed a commit
to ufispace-dev/sonic-buildimage
that referenced
this pull request
Apr 2, 2024
It appears that this was initially added to provide the git-retry command (which doesn't appear to be used today). However, this repo is now also providing bazel (which is actually used in our build today), and this command (along with git-retry) expects some vpython3 binary to be set up/installed. Rather than going through that, just get rid of this repo.
tigerfu000
pushed a commit
to tigerfu000/ec-sonic-buildimage
that referenced
this pull request
Jul 4, 2024
Apply community PR : sonic-net/sonic-buildimage#14293 Detail: sonic-net/sonic-buildimage#14292 as4630-54npe already merge(at commit id: 4be14f0) the PRs below: sonic-net/sonic-buildimage#13241 sonic-net/sonic-buildimage#13288 sonic-net/sonic-buildimage#15002 sonic-net/sonic-buildimage#13685 sonic-net/sonic-buildimage#14475 sonic-net/sonic-buildimage#14993 sonic-net/sonic-buildimage#14919 sonic-net/sonic-buildimage#15461 sonic-net/sonic-buildimage#16114 sonic-net/sonic-buildimage#334
vincentchiang-ec
pushed a commit
to vincentchiang-ec/sonic-buildimage-vincentchiang
that referenced
this pull request
Aug 16, 2024
Apply community PR : sonic-net/sonic-buildimage#14293 Detail: sonic-net/sonic-buildimage#14292 as4630-54npe already merge(at commit id: 4be14f0) the PRs below: sonic-net/sonic-buildimage#13241 sonic-net/sonic-buildimage#13288 sonic-net/sonic-buildimage#15002 sonic-net/sonic-buildimage#13685 sonic-net/sonic-buildimage#14475 sonic-net/sonic-buildimage#14993 sonic-net/sonic-buildimage#14919 sonic-net/sonic-buildimage#15461 sonic-net/sonic-buildimage#16114 sonic-net/sonic-buildimage#334
vincentchiang-ec
pushed a commit
to edge-core/sonic-buildimage
that referenced
this pull request
Aug 16, 2024
Apply community PR : sonic-net/sonic-buildimage#14293 Detail: sonic-net/sonic-buildimage#14292 as4630-54npe already merge(at commit id: 4be14f0) the PRs below: sonic-net/sonic-buildimage#13241 sonic-net/sonic-buildimage#13288 sonic-net/sonic-buildimage#15002 sonic-net/sonic-buildimage#13685 sonic-net/sonic-buildimage#14475 sonic-net/sonic-buildimage#14993 sonic-net/sonic-buildimage#14919 sonic-net/sonic-buildimage#15461 sonic-net/sonic-buildimage#16114 sonic-net/sonic-buildimage#334
tigerfu000
pushed a commit
to tigerfu000/ec-sonic-buildimage
that referenced
this pull request
Jan 22, 2025
Apply community PR : sonic-net/sonic-buildimage#14293 Detail: sonic-net/sonic-buildimage#14292 as4630-54npe already merge(at commit id: 4be14f0) the PRs below: sonic-net/sonic-buildimage#13241 sonic-net/sonic-buildimage#13288 sonic-net/sonic-buildimage#15002 sonic-net/sonic-buildimage#13685 sonic-net/sonic-buildimage#14475 sonic-net/sonic-buildimage#14993 sonic-net/sonic-buildimage#14919 sonic-net/sonic-buildimage#15461 sonic-net/sonic-buildimage#16114 sonic-net/sonic-buildimage#334
tigerfu000
pushed a commit
to tigerfu000/ec-sonic-buildimage
that referenced
this pull request
Feb 7, 2025
Apply community PR : sonic-net/sonic-buildimage#14293 Detail: sonic-net/sonic-buildimage#14292 as4630-54npe already merge(at commit id: 4be14f0) the PRs below: sonic-net/sonic-buildimage#13241 sonic-net/sonic-buildimage#13288 sonic-net/sonic-buildimage#15002 sonic-net/sonic-buildimage#13685 sonic-net/sonic-buildimage#14475 sonic-net/sonic-buildimage#14993 sonic-net/sonic-buildimage#14919 sonic-net/sonic-buildimage#15461 sonic-net/sonic-buildimage#16114 sonic-net/sonic-buildimage#334
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
It appears that this was initially added to provide the
git-retrycommand (which doesn't appear to be used today). However, this repo is now also providingbazel(which is actually used in our build today), and this command (along withgit-retry) expects somevpython3binary to be set up/installed. The sonic-p4rt code runsbazel, which means this depot_tools version would get called instead of the regular system-installed version.Rather than going through the process of setting up/installing vpython3, just get rid of this repo.
Fixes #16087.
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)