[buildsystem] Fix hiredis package version: 0.14.1-1 by nazariig · Pull Request #15461 · sonic-net/sonic-buildimage

nazariig · 2023-06-14T17:52:54Z

Build error:

18:20:27  [ finished ] [ target/debs/buster/libhiredis0.14_0.14.0-3~bpo9+1_amd64.deb ]
18:20:27  [ FAIL LOG START ] [ target/debs/buster/libhiredis0.14_0.14.0-3~bpo9+1_amd64.deb ]
18:20:27  [ REASON ] :      target/debs/buster/libhiredis0.14_0.14.0-3~bpo9+1_amd64.deb does not exist  
18:20:27  [ FLAGS  FILE    ] : [mellanox amd64 buster y buster]
18:20:27  [ FLAGS  DEPENDS ] : [mellanox amd64 buster y buster]
18:20:27  [ FLAGS  DIFF    ] : []
18:20:27  make[1]: warning: -j30 forced in submake: resetting jobserver mode.
18:20:27  make[1]: Entering directory '/sonic/src/hiredis'
18:20:27  rm -rf hiredis-0.14.0
18:20:27  wget -O hiredis_0.14.0.orig.tar.gz http://http.debian.net/debian/pool/main/h/hiredis/hiredis_0.14.0.orig.tar.gz
18:20:27  wget -O hiredis_0.14.0-3~bpo9+1.debian.tar.xz http://http.debian.net/debian/pool/main/h/hiredis/hiredis_0.14.0-3~bpo9+1.debian.tar.xz
18:20:27  wget -O hiredis_0.14.0-3~bpo9+1.dsc http://http.debian.net/debian/pool/main/h/hiredis/hiredis_0.14.0-3~bpo9+1.dsc
18:20:27  dpkg-source -x hiredis_0.14.0-3~bpo9+1.dsc
18:20:27  pushd hiredis-0.14.0
18:20:27  dpkg-buildpackage -rfake******** -d -b -us -uc -j30 --********dir /sonic/dpkg/tmp.ALm1Mqoiea
18:20:27  popd
18:20:27  mv libhiredis0.14_0.14.0-3~bpo9+1_amd64.deb libhiredis0.14-dbgsym_0.14.0-3~bpo9+1_amd64.deb libhiredis-dev_0.14.0-3~bpo9+1_amd64.deb /sonic/target/debs/buster/
18:20:27  /usr/local/share/buildinfo/scripts/buildinfo_base.sh: line 165: /usr/local/share/buildinfo/build-versions/versions-web: Permission denied
18:20:27  --2023-06-14 15:20:25--  http://http.debian.net/debian/pool/main/h/hiredis/hiredis_0.14.0.orig.tar.gz
18:20:27  Resolving http.debian.net (http.debian.net)... 130.89.148.77, 128.31.0.62, 149.20.4.15, ...
18:20:27  Connecting to http.debian.net (http.debian.net)|130.89.148.77|:80... connected.
18:20:27  HTTP request sent, awaiting response... 302 Found
18:20:27  Location: http://cdn-fastly.deb.debian.org/debian/pool/main/h/hiredis/hiredis_0.14.0.orig.tar.gz [following]
18:20:27  --2023-06-14 15:20:25--  http://cdn-fastly.deb.debian.org/debian/pool/main/h/hiredis/hiredis_0.14.0.orig.tar.gz
18:20:27  Resolving cdn-fastly.deb.debian.org (cdn-fastly.deb.debian.org)... 146.75.122.132, 2a04:4e42:8e::644
18:20:27  Connecting to cdn-fastly.deb.debian.org (cdn-fastly.deb.debian.org)|146.75.122.132|:80... connected.
18:20:27  HTTP request sent, awaiting response... 200 OK
18:20:27  Length: 63061 (62K) [application/x-gzip]
18:20:27  Saving to: 'hiredis_0.14.0.orig.tar.gz'
18:20:27  
18:20:27       0K .......... .......... .......... .......... .......... 81%  716K 0s
18:20:27      50K .......... .                                          100% 1.79M=0.08s
18:20:27  
18:20:27  2023-06-14 15:20:26 (809 KB/s) - 'hiredis_0.14.0.orig.tar.gz' saved [63061/63061]
18:20:27  
18:20:27  /usr/local/share/buildinfo/scripts/buildinfo_base.sh: line 165: /usr/local/share/buildinfo/build-versions/versions-web: Permission denied
18:20:27  --2023-06-14 15:20:26--  http://http.debian.net/debian/pool/main/h/hiredis/hiredis_0.14.0-3~bpo9+1.debian.tar.xz
18:20:27  Resolving http.debian.net (http.debian.net)... 149.20.4.15, 130.89.148.77, 128.31.0.62, ...
18:20:27  Connecting to http.debian.net (http.debian.net)|149.20.4.15|:80... connected.
18:20:27  HTTP request sent, awaiting response... 302 Found
18:20:27  Location: http://cdn-fastly.deb.debian.org/debian/pool/main/h/hiredis/hiredis_0.14.0-3~bpo9+1.debian.tar.xz [following]
18:20:27  --2023-06-14 15:20:27--  http://cdn-fastly.deb.debian.org/debian/pool/main/h/hiredis/hiredis_0.14.0-3~bpo9+1.debian.tar.xz
18:20:27  Resolving cdn-fastly.deb.debian.org (cdn-fastly.deb.debian.org)... 146.75.122.132, 2a04:4e42:8e::644
18:20:27  Connecting to cdn-fastly.deb.debian.org (cdn-fastly.deb.debian.org)|146.75.122.132|:80... connected.
18:20:27  HTTP request sent, awaiting response... 404 Not Found
18:20:27  2023-06-14 15:20:27 ERROR 404: Not Found.
18:20:27  
18:20:27  make[1]: *** [Makefile:9: /sonic/target/debs/buster/libhiredis0.14_0.14.0-3~bpo9+1_amd64.deb] Error 8
18:20:27  make[1]: Leaving directory '/sonic/src/hiredis'
18:20:27  [  FAIL LOG END  ] [ target/debs/buster/libhiredis0.14_0.14.0-3~bpo9+1_amd64.deb ]
18:20:27  make: *** [slave.mk:658: target/debs/buster/libhiredis0.14_0.14.0-3~bpo9+1_amd64.deb] Error 1
18:20:27  make: *** Waiting for unfinished jobs....

Why I did it

To fix hiredis compilation

Work item tracking

N/A

How I did it

Changed package version: 0.14.0-3~bpo9+1 -> 0.14.1-1

How to verify it

make configure PLATFORM=mellanox
make target/sonic-mellanox.bin

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

master

Description for the changelog

N/A

Link to config_db schema for YANG module changes

N/A

A picture of a cute animal (not mandatory but encouraged)

      .---.        .-----------
     /     \  __  /    ------
    / /     \(  )/    -----
   //////   ' \/ `   ---
  //// / // :    : ---
 // /   /  /`    '--
//          //..\\
       ====UU====UU====
           '//||\\`
             ''``

Signed-off-by: Nazarii Hnydyn <[email protected]>

liushilongbuaa · 2023-06-16T09:46:40Z

Yes, hiredis_0.14.0-3~bpo9+1 is not available on debian.org.
But it seems that hiredis_0.14.0-3 will also deprecated at 2023-11-04.

liushilongbuaa · 2023-06-16T09:59:00Z

@xumia, @qiluo-msft , there are a lot of debian packages deprecated by debian.org each year.
Updating these packages to newer version is a heavy job. Can we use apt-get download instead of wget/dget?

apt-get download libhiredis0.14

nazariig · 2023-06-16T10:43:49Z

@liushilongbuaa this is a blocker for us. Can we temporary use this solution until long term discussion is in progress?

liushilongbuaa · 2023-06-16T10:56:15Z

@liushilongbuaa this is a blocker for us. Can we temporary use this solution until long term discussion is in progress?

Currently, LGTM. But I need to check pipeline log to confirm.

nazariig · 2023-06-16T13:34:41Z

@liushilongbuaa would you please help to merge?

Backport of: #15461 Why I did it To fix hiredis compilation Work item tracking N/A How I did it Changed package version: 0.14.0-3~bpo9+1 -> 0.14.0-3

rules/hiredis.mk

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig · 2023-06-19T14:28:28Z

@StormLiangMS can you please merge?

nazariig · 2023-06-20T10:17:54Z

@xumia can you please merge if no more comments?

k-v1 · 2023-06-20T11:29:30Z

Probably need to update title/description if version was changed to 0.14.1

abdosi · 2023-06-20T15:08:50Z

@yxieca we need this for 202205 as build are failing for that also.

@gechiang for viz.

developfast · 2023-06-28T19:16:05Z

202205 cherry-pick: #15651

mssonicbld · 2023-06-29T00:20:29Z

@nazariig PR conflicts with 202012 branch

* [buildsystem] Fix hiredis package version: 0.14.1-1 (#15461) - Why I did it To fix hiredis compilation - How I did it Changed package version: 0.14.0-3~bpo9+1 -> 0.14.1-1 - How to verify it make configure PLATFORM=mellanox make target/sonic-mellanox.bin Signed-off-by: Nazarii Hnydyn <[email protected]> * Update Makefile --------- Signed-off-by: Nazarii Hnydyn <[email protected]> Co-authored-by: Nazarii Hnydyn <[email protected]>

StormLiangMS · 2023-06-29T09:00:05Z

@nazariig could you help to create separate PR for 202305, cherry pick failure.

nazariig · 2023-06-29T11:23:31Z

@nazariig could you help to create separate PR for 202305, cherry pick failure.

@StormLiangMS It is already done: #15569

…sonic-net#15651) * [buildsystem] Fix hiredis package version: 0.14.1-1 (sonic-net#15461) - Why I did it To fix hiredis compilation - How I did it Changed package version: 0.14.0-3~bpo9+1 -> 0.14.1-1 - How to verify it make configure PLATFORM=mellanox make target/sonic-mellanox.bin Signed-off-by: Nazarii Hnydyn <[email protected]> * Update Makefile --------- Signed-off-by: Nazarii Hnydyn <[email protected]> Co-authored-by: Nazarii Hnydyn <[email protected]>

liuh-80 · 2023-07-05T09:08:54Z

@nazariig , this PR has merge conflict when on 202012 branch, please create manually cherry-pick PR to 202012.

nazariig · 2023-07-05T11:19:35Z

@nazariig , this PR has merge conflict when on 202012 branch, please create manually cherry-pick PR to 202012.

@liuh-80 done

Backport #15461 #### Why I did it * To fix `hiredis` compilation #### How I did it * Changed package version: `0.14.0-3~bpo9+1` -> `0.14.1-1` #### How to verify it 1. make configure PLATFORM=mellanox 2. make target/sonic-mellanox.bin #### Tested branch (Please provide the tested image version) - [X] 202012

- Why I did it To fix hiredis compilation - How I did it Changed package version: 0.14.0-3~bpo9+1 -> 0.14.1-1 - How to verify it make configure PLATFORM=mellanox make target/sonic-mellanox.bin Signed-off-by: Nazarii Hnydyn <[email protected]>

Apply community PR : sonic-net/sonic-buildimage#14293 Detail: sonic-net/sonic-buildimage#14292 as4630-54npe already merge(at commit id: 4be14f0) the PRs below: sonic-net/sonic-buildimage#13241 sonic-net/sonic-buildimage#13288 sonic-net/sonic-buildimage#15002 sonic-net/sonic-buildimage#13685 sonic-net/sonic-buildimage#14475 sonic-net/sonic-buildimage#14993 sonic-net/sonic-buildimage#14919 sonic-net/sonic-buildimage#15461 sonic-net/sonic-buildimage#16114 sonic-net/sonic-buildimage#334

…net#15719) Backport sonic-net#15461 #### Why I did it * To fix `hiredis` compilation #### How I did it * Changed package version: `0.14.0-3~bpo9+1` -> `0.14.1-1` #### How to verify it 1. make configure PLATFORM=mellanox 2. make target/sonic-mellanox.bin #### Tested branch (Please provide the tested image version) - [X] 202012

- Why I did it To fix hiredis compilation - How I did it Changed package version: 0.14.0-3~bpo9+1 -> 0.14.1-1 - How to verify it make configure PLATFORM=mellanox make target/sonic-mellanox.bin Signed-off-by: Nazarii Hnydyn <[email protected]>

Apply community PR : sonic-net/sonic-buildimage#14293 Detail: sonic-net/sonic-buildimage#14292 as4630-54npe already merge(at commit id: 4be14f0) the PRs below: sonic-net/sonic-buildimage#13241 sonic-net/sonic-buildimage#13288 sonic-net/sonic-buildimage#15002 sonic-net/sonic-buildimage#13685 sonic-net/sonic-buildimage#14475 sonic-net/sonic-buildimage#14993 sonic-net/sonic-buildimage#14919 sonic-net/sonic-buildimage#15461 sonic-net/sonic-buildimage#16114 sonic-net/sonic-buildimage#334

nazariig requested review from lguohan, qiluo-msft and xumia as code owners June 14, 2023 17:52

nazariig added Build Bug 🐛 labels Jun 14, 2023

nazariig requested review from liat-grozovik, liushilongbuaa and volodymyrsamotiy June 14, 2023 17:57

nazariig mentioned this pull request Jun 15, 2023

[202211][buildsystem]: Fix hiredis package version: 0.14.0-3. #15476

Merged

9 tasks

[buildsystem]: Fix hiredis package version: 0.14.0-3.

7fad015

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig force-pushed the master-hiredis-fix branch from db01b6b to 7fad015 Compare June 16, 2023 08:34

nazariig added the Request for 202205 Branch label Jun 16, 2023

k-v1 approved these changes Jun 18, 2023

View reviewed changes

StormLiangMS added the Included in 202211 Branch label Jun 19, 2023

xumia reviewed Jun 19, 2023

View reviewed changes

rules/hiredis.mk Outdated Show resolved Hide resolved

[buildsystem]: Handle review comments.

5888d4f

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig changed the title ~~[buildsystem]: Fix hiredis package version: 0.14.0-3~~ [buildsystem]: Fix hiredis package version: 0.14.1-1 Jun 20, 2023

xumia approved these changes Jun 20, 2023

View reviewed changes

liat-grozovik merged commit d9dfb36 into sonic-net:master Jun 20, 2023

liat-grozovik changed the title ~~[buildsystem]: Fix hiredis package version: 0.14.1-1~~ [buildsystem] Fix hiredis package version: 0.14.1-1 Jun 20, 2023

liuh-80 added the Approved for 202012 Branch label Jun 29, 2023

mssonicbld added the Cherry Pick Conflict_202012 label Jun 29, 2023

yxieca added Included in 202205 Branch and removed Approved for 202205 Branch labels Jun 29, 2023

liuh-80 added the Created PR to 202012 Branch label Jul 6, 2023

qiluo-msft mentioned this pull request Jul 10, 2023

[202012][buildsystem]: Fix hiredis package version: 0.14.1-1 #15719

Merged

10 tasks

StormLiangMS added the Included in 202305 Branch label Jul 17, 2023

ec-michael-shih mentioned this pull request Dec 5, 2023

[AS4630-54PE] Apply community PR edge-core/sonic-buildimage#13

Merged

7 tasks

ec-michael-shih mentioned this pull request Dec 12, 2023

[AS4630-54NPE] Apply community PR edge-core/sonic-buildimage#17

Merged

ec-michael-shih mentioned this pull request Jan 3, 2024

[AS9736-64d] Apply community PR edge-core/sonic-buildimage#24

Merged

7 tasks

Conversation

nazariig commented Jun 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

liushilongbuaa commented Jun 16, 2023

Uh oh!

liushilongbuaa commented Jun 16, 2023

Uh oh!

nazariig commented Jun 16, 2023

Uh oh!

liushilongbuaa commented Jun 16, 2023

Uh oh!

nazariig commented Jun 16, 2023

Uh oh!

Uh oh!

nazariig commented Jun 19, 2023

Uh oh!

nazariig commented Jun 20, 2023

Uh oh!

k-v1 commented Jun 20, 2023

Uh oh!

abdosi commented Jun 20, 2023

Uh oh!

developfast commented Jun 28, 2023

Uh oh!

mssonicbld commented Jun 29, 2023

Uh oh!

StormLiangMS commented Jun 29, 2023

Uh oh!

nazariig commented Jun 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liuh-80 commented Jul 5, 2023

Uh oh!

nazariig commented Jul 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

nazariig commented Jun 14, 2023 •

edited

Loading

nazariig commented Jun 29, 2023 •

edited

Loading