Skip to content

[tacacs] Avoid printing credential into syslog #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
taoyl-ms wants to merge 1 commit into from
Closed

[tacacs] Avoid printing credential into syslog #1443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions files/image_config/hostcfgd/hostcfgd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ def sub(l, start, end):
return l[start:end]


def scrub(data):
if data:
return data[0] + '*****'
else:
return data

class AaaCfg(object):
def __init__(self):
self.auth_default = {
Expand Down Expand Up @@ -148,11 +154,17 @@ class HostConfigDaemon:
self.aaacfg.aaa_update(key, data)

def tacacs_server_handler(self, key, data):
syslog.syslog(syslog.LOG_DEBUG, 'value for {} changed to {}'.format(key, data))
if key == 'passkey':
syslog.syslog(syslog.LOG_DEBUG, 'value for {} changed to {}'.format(key, scrub(data))
else:
syslog.syslog(syslog.LOG_DEBUG, 'value for {} changed to {}'.format(key, data))
self.aaacfg.tacacs_server_update(key, data)

def tacacs_global_handler(self, key, data):
syslog.syslog(syslog.LOG_DEBUG, 'value for {} changed to {}'.format(key, data))
if key == 'passkey':
syslog.syslog(syslog.LOG_DEBUG, 'value for {} changed to {}'.format(key, scrub(data))
else:
syslog.syslog(syslog.LOG_DEBUG, 'value for {} changed to {}'.format(key, data))
self.aaacfg.tacacs_global_update(key, data)

def start(self):
Expand Down