Skip to content

[tacacs] Avoid printing credential into syslog#1443

Closed
taoyl-ms wants to merge 1 commit intosonic-net:masterfrom
taoyl-ms:taoyl/scrub
Closed

[tacacs] Avoid printing credential into syslog#1443
taoyl-ms wants to merge 1 commit intosonic-net:masterfrom
taoyl-ms:taoyl/scrub

Conversation

@taoyl-ms
Copy link
Contributor

@taoyl-ms taoyl-ms commented Mar 2, 2018

- What I did
hostcfgd print debug information into syslog when any tacacs-related field changes, which include confidential information (passkey). This change is to scrub the key before printing it into syslog.

@taoyl-ms taoyl-ms requested a review from lguohan March 2, 2018 02:07
@taoyl-ms taoyl-ms closed this Mar 2, 2018
abdosi added a commit to abdosi/sonic-buildimage that referenced this pull request Sep 29, 2020
be51ebc Add IPv6 key item support to request parser (sonic-net#1449)
76e2251 When teamd feature state is disabled the Netdevice created by teamd were (sonic-net#1450)
6aa97ce Use .clear() after std::move() (sonic-net#1444)
d5757db Add libzmq to README dependencies (sonic-net#1447)
c7b262e Add libzmq to Makefiles (sonic-net#1443)
0b2e59a [drop counters] Clarify log messages for initial counter setup (sonic-net#1445)
003cf24 [dvs] Refactor and add buffer pool wm test (sonic-net#1446)
2f5d2d9 [acl] Remove Ethertype from L3V6 qualifiers (sonic-net#1433)
f7b974f Fix issue: bufferorch only pass the first attribute to sai when setting attribute (sonic-net#1442)

Signed-off-by: Abhishek Dosi <[email protected]>
@abdosi abdosi mentioned this pull request Sep 29, 2020
3 tasks
lguohan pushed a commit that referenced this pull request Oct 2, 2020
be51ebc Add IPv6 key item support to request parser (#1449)
76e2251 When teamd feature state is disabled the Netdevice created by teamd were (#1450)
6aa97ce Use .clear() after std::move() (#1444)
d5757db Add libzmq to README dependencies (#1447)
c7b262e Add libzmq to Makefiles (#1443)
0b2e59a [drop counters] Clarify log messages for initial counter setup (#1445)
003cf24 [dvs] Refactor and add buffer pool wm test (#1446)
2f5d2d9 [acl] Remove Ethertype from L3V6 qualifiers (#1433)
f7b974f Fix issue: bufferorch only pass the first attribute to sai when setting attribute (#1442)

Signed-off-by: Abhishek Dosi <[email protected]>
abdosi added a commit that referenced this pull request Feb 19, 2021
02438f953aafa3303792eda2309f8f3303e55dc7 (HEAD -> 201911, origin/201911) Cherry-pick Master PR for route-checker tool (#1433)
e54fb69f7323f6ef48f44a1a893fe8266fd6f817 [201911][vnet] Add "vnet_route_check" script (#1443)

Signed-off-by: Abhishek Dosi <[email protected]>
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
be51ebc Add IPv6 key item support to request parser (sonic-net#1449)
76e2251 When teamd feature state is disabled the Netdevice created by teamd were (sonic-net#1450)
6aa97ce Use .clear() after std::move() (sonic-net#1444)
d5757db Add libzmq to README dependencies (sonic-net#1447)
c7b262e Add libzmq to Makefiles (sonic-net#1443)
0b2e59a [drop counters] Clarify log messages for initial counter setup (sonic-net#1445)
003cf24 [dvs] Refactor and add buffer pool wm test (sonic-net#1446)
2f5d2d9 [acl] Remove Ethertype from L3V6 qualifiers (sonic-net#1433)
f7b974f Fix issue: bufferorch only pass the first attribute to sai when setting attribute (sonic-net#1442)

Signed-off-by: Abhishek Dosi <[email protected]>
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
libzmq is required since orchagent will compile against libsairedis
mssonicbld added a commit that referenced this pull request Nov 16, 2024
…tically (#20830)

#### Why I did it
src/sonic-sairedis
```
* 137b538e - (HEAD -> master, origin/master, origin/HEAD) Use a different letter to represent counter polling in sairedis.rec to avoid saiplayer crash (#1443) (19 hours ago) [Stephen Sun]
* 95b3b353 - Support SAI_QUEUE_ATTR_TYPE on vs platform simulating MLNX2700 (#1459) (20 hours ago) [Stephen Sun]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant