Skip to content

Update sonic-py-common, add missing dependency to redis-dump-load. #14347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qiluo-msft merged 2 commits into from
Mar 23, 2023
Merged

Update sonic-py-common, add missing dependency to redis-dump-load. #14347

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0e6170
Update sonic-swss-common, add missing dependency to redis-dump-load.
liuh-80 Mar 20, 2023
6b2db91
CHange to use sonic_dependencies
liuh-80 Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/sonic-py-common/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
dependencies = [
'natsort==6.2.1', # 6.2.1 is the last version which supports Python 2
'pyyaml',
'redis-dump-load',
Copy link
Copy Markdown
Collaborator

@qiluo-msft qiluo-msft Mar 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redis-dump-load

Thanks for the fixing!
Since we build redis-dump-load with patch, we never expect setup.py automatically download it from pypi. We enforce this rule by treating it as "sonic_dependencies". Could you follow the sample in https://github.com/sonic-net/sonic-buildimage/pull/13850/files #Closed

Copy link
Copy Markdown
Contributor Author

@liuh-80 liuh-80 Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, also create a manually cherry-pick PR for 202211 and 202205: #14360

]

setup(
Expand Down