Update sonic-py-common, add missing dependency to redis-dump-load.#14347
Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom Mar 23, 2023
Merged
Update sonic-py-common, add missing dependency to redis-dump-load.#14347qiluo-msft merged 2 commits intosonic-net:masterfrom
qiluo-msft merged 2 commits intosonic-net:masterfrom
Conversation
7 tasks
qiluo-msft
reviewed
Mar 20, 2023
src/sonic-py-common/setup.py
Outdated
| dependencies = [ | ||
| 'natsort==6.2.1', # 6.2.1 is the last version which supports Python 2 | ||
| 'pyyaml', | ||
| 'redis-dump-load', |
Collaborator
There was a problem hiding this comment.
Thanks for the fixing!
Since we build redis-dump-load with patch, we never expect setup.py automatically download it from pypi. We enforce this rule by treating it as "sonic_dependencies". Could you follow the sample in https://github.com/sonic-net/sonic-buildimage/pull/13850/files #Closed
Contributor
Author
There was a problem hiding this comment.
Fixed, also create a manually cherry-pick PR for 202211 and 202205: #14360
This was referenced Mar 21, 2023
qiluo-msft
pushed a commit
that referenced
this pull request
Mar 23, 2023
…-load (#14360) Update sonic-py-common, add missing dependency to redis-dump-load. This is manually cherry-pick PR for #14347 After 202211, the redis-dump-load been patched by sonic, so can't cherry-pick master branch PR to 202211 branch. #### Why I did it The script sonic_db_dump_load.py in sonic-py-common is depends on redis-dump-load, however the dependency is missing. #### How I did it Add redis-dump-load dependency. #### How to verify it Pass all E2E test case. #### Description for the changelog Update sonic-py-common, add missing dependency to redis-dump-load.
qiluo-msft
approved these changes
Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update sonic-py-common, add missing dependency to redis-dump-load.
Why I did it
The script sonic_db_dump_load.py in sonic-py-common is depends on redis-dump-load, however the dependency is missing.
How I did it
Add redis-dump-load dependency.
How to verify it
Pass all E2E test case.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Update sonic-py-common, add missing dependency to redis-dump-load.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)