Apply the SAI patch to fix the header file not found issue#13699
Draft
xumia wants to merge 5 commits intosonic-net:masterfrom
Draft
Apply the SAI patch to fix the header file not found issue#13699xumia wants to merge 5 commits intosonic-net:masterfrom
xumia wants to merge 5 commits intosonic-net:masterfrom
Conversation
richardyu-ms
approved these changes
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
It is to fix the build broken issue.
https://dev.azure.com/mssonic/build/_build/results?buildId=213554&view=logs&j=88ce9a53-729c-5fa9-7b6e-3d98f2488e3f&t=8d99be27-49d0-54d0-99b1-cfc0d47f0318
How I did it
Apply the SAI patch to fix the header file not found issue, see opencomputeproject/SAI#1727 (comment)
The PR can be removed when the patch of the sai that has updated in sonic-sairedis.
The applied SAI patch is not in the same folder of the source folder, we need to apply the patch by a command in Makefile.
How to verify it
make SONIC_BUILD_JOBS=4 target/debs/bullseye/libsaithriftv2-dev_0.9.4_amd64.deb ENABLE_SYNCD_RPC=y SAITHRIFT_V2=y
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)