improve enum values integration check#1727
Conversation
it allows to use two different 'experimental' dirs during integration check, one belongs to current repository and another to origin/master Signed-off-by: Anton Parkhomenko <[email protected]>
71d0fb2 to
77f1829
Compare
|
@marian-pritsak , could you please take a look? |
|
@xumia for viz |
|
@prsunny shouldn't this be cherry-picked into v1.11 to update the refoint in sairedis then? Currently, that issue caused Barefoot and Broadcom SONiC build to fails |
|
dash changes are not backported to v1.11. can you update this submodule on sairedis instead? |
Is the v1.11 used by 202205+? |
|
@xumia I think cherry-pinking of this fix will not help. This fix will work only for version that will be based on current latest master. |
@aparkhomenko-xsight , yes, adding a patch for it is a workaround for the existing old commit reference. |
it allows to use two different 'experimental' dirs during integration check, one belongs to current repository and another to origin/master Signed-off-by: Anton Parkhomenko <[email protected]>
it allows to use two different 'experimental' dirs during integration check, one belongs to current repository and another to origin/master Signed-off-by: Anton Parkhomenko <[email protected]> Co-authored-by: aparkhomenko-xsight <[email protected]>
it allows to use two different 'experimental' dirs during integration check, one belongs to current repository and another to origin/master Signed-off-by: Anton Parkhomenko <[email protected]>
it allows to use two different 'experimental' dirs during integration check, one belongs to current repository and another to origin/master Signed-off-by: Anton Parkhomenko <[email protected]> Co-authored-by: aparkhomenko-xsight <[email protected]>
What I did?
I added dedicated 'expiremantal' dir which belongs to origin/master during enum values integration check
Why I did it ?
It fixes issue when content of current repo's 'expiremantal' dir differs from origin/master, in simplest case current repo doesn't point to latest master (what is a common case)
If new files were added to 'experental' dir and current repo don't have them checkenumlock.sh would fail
I faced this issue when DASH API were merged.