[Cherry-pick] Add build target to build thrift 0.14.1 for python2#12828
Merged
Gfrom2016 merged 2 commits intosonic-net:202205from Nov 26, 2022
Merged
[Cherry-pick] Add build target to build thrift 0.14.1 for python2#12828Gfrom2016 merged 2 commits intosonic-net:202205from
Gfrom2016 merged 2 commits intosonic-net:202205from
Conversation
Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
Gfrom2016
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
richardyu-ms
approved these changes
Nov 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
This PR is a cherry-pick of #12790 and a revert of #12169 to add build target to help build thrift 0.14.1 for python2.
PYTHON_THRIFT_0_14_1 couldn't be built on the pipeline which caused some building targets to fail, like docker-saiserverv2.
In order to make the thrift 0.14.1 can be used by other build targets and prepare for the latter upgrade from thrift 0.11 to 0.14.1. Add this target.
How I did it
Cherry-pick #12790 from master to 202205 and re-add the target PYTHON_THRIFT_0_14_1.
How to verify it
Local docker build.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: zitingguo-ms zitingguo@microsoft.com