Add build target to build thrift 014 for python2#12790
Merged
richardyu-ms merged 1 commit intosonic-net:masterfrom Nov 22, 2022
Merged
Add build target to build thrift 014 for python2#12790richardyu-ms merged 1 commit intosonic-net:masterfrom
richardyu-ms merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
richardyu-ms
changed the title
richardyu-ms
changed the title
liushilongbuaa
approved these changes
Nov 22, 2022
Gfrom2016
pushed a commit
to Gfrom2016/sonic-buildimage
that referenced
this pull request
Nov 25, 2022
Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
7 tasks
Gfrom2016
added a commit
that referenced
this pull request
Nov 26, 2022
…2828) * add build target thrift 014 for python2 (#12790) Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * readd target PYTHON_THRIFT_0_14_1 Signed-off-by: zitingguo-ms <zitingguo@microsoft.com> Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: zitingguo-ms <zitingguo@microsoft.com> Co-authored-by: Richard.Yu <richard.yu@microsoft.com>
8 tasks
Collaborator
|
@richardyu-ms PR conflicts with 202211 branch |
Contributor
|
@liushilongbuaa this PR has been manually cherry-picked to 202211 in #12935 |
Contributor
|
thanks! |
StormLiangMS
pushed a commit
to StormLiangMS/sonic-buildimage
that referenced
this pull request
Dec 8, 2022
Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
PYTHON_THRIFT_0_14_1 couldn't be built on the pipeline which caused some building target failed, likedocker-saiserverv2.
In order to make the thrift 0.14.1 can be used by other build target and prepare for latter upgrade from thrift 0.11 to 0.14. Add this target.
Without this target the error is
This fix can also resolve the previous issue in PR #12169
How I did it
Add the build target for python-thrift_0.14.1_amd64.deb in thrift make file.
How to verify it
Local docker build
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)