Skip to content

[openssh] Update openssh make file, add missing dependency to libnl. #12327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liuh-80 merged 2 commits into from
Oct 24, 2022
Merged

[openssh] Update openssh make file, add missing dependency to libnl. #12327

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42836c4
Update openssh make file, add missing depency to libnl.
liuh-80 Oct 10, 2022
92705a6
Fix dpkg lock issue
liuh-80 Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rules/openssh.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ export OPENSSH_VERSION

OPENSSH_SERVER = openssh-server_$(OPENSSH_VERSION)_$(CONFIGURED_ARCH).deb
$(OPENSSH_SERVER)_SRC_PATH = $(SRC_PATH)/openssh
$(OPENSSH_SERVER)_DEPENDS += $(LIBNL3_DEV) $(LIBNL_ROUTE3_DEV)
Copy link
Copy Markdown
Collaborator

@qiluo-msft qiluo-msft Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LIBNL_ROUTE3_DEV

Seem this fix is a valid fix, and has no relationship with the other PR 12447 .

I am worried about why this bug is not exposed before? Could you check previous build log and possible find a build bug?

Copy link
Copy Markdown
Collaborator

@qiluo-msft qiluo-msft Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xumia please be aware of this issue.

Copy link
Copy Markdown
Contributor Author

@liuh-80 liuh-80 Oct 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LIBNL_ROUTE3_DEV

Seem this fix is a valid fix, and has no relationship with the other PR 12447 .

I am worried about why this bug is not exposed before? Could you check previous build log and possible find a build bug?

I checked the build log and not found build issue caused by this.
When build on local devbox or run a full build, in most case we build everything from source code, so the libnl will be build and install before openssh build.

Here is how this issue happen:
When build on azure pipeline, we are using cache, so when change openssh code, the libnl will not build because there is no code change, also libnl will not be installed from cache. then openssh will build break because missing package.

SONIC_MAKE_DEBS += $(OPENSSH_SERVER)

# The .c, .cpp, .h & .hpp files under src/{$DBG_SRC_ARCHIVE list}
Expand Down