[openssh] Update openssh make file, add missing dependency to libnl. by liuh-80 · Pull Request #12327 · sonic-net/sonic-buildimage

liuh-80 · 2022-10-10T02:37:50Z

Update openssh make file, add missing dependency to libnl.

Why I did it

Openssh indirectly depends on libnl.
Another PR #12447 need add new patch to openssh, after adding new patch to openssh, PR build failed with libnl missing error.

How I did it

Update openssh make file, add missing dependency to libnl.

How to verify it

Pass all test case

Which release branch to backport (provide reason below if selected)

Description for the changelog

Update openssh make file, add missing dependency to libnl.

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

liuh-80 · 2022-10-10T08:30:19Z

Close, now sonic using fips version.

liuh-80 · 2022-10-20T02:20:27Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2022-10-20T02:20:40Z

Azure Pipelines successfully started running 1 pipeline(s).

liuh-80 · 2022-10-20T02:30:48Z

Here is openssh build error:

2022-10-19T09:45:14.5743687Z The following packages have unmet dependencies:
2022-10-19T09:45:14.5744821Z libibverbs1 : Depends: libnl-route-3-200 (>= 3.2.7) but it is not going to be installed
2022-10-19T09:45:14.5745774Z E: Error, pkgProblemResolver::Resolve generated breaks, this may be caused by held packages.
2022-10-19T09:45:14.5747200Z make[1]: *** [Makefile:9: /sonic/target/debs/bullseye/openssh-server_8.4p1-5+deb11u1_amd64.deb] Error 100

liuh-80 · 2022-10-20T03:23:15Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2022-10-20T03:23:27Z

Azure Pipelines successfully started running 1 pipeline(s).

liuh-80 · 2022-10-20T05:59:32Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2022-10-20T05:59:43Z

Azure Pipelines successfully started running 1 pipeline(s).

liuh-80 · 2022-10-20T06:00:37Z

Build failed with this error, seems a agent pool issue:
E: Could not get lock /var/lib/dpkg/lock-frontend. It is held by process 58398 (dpkg)
E: Unable to acquire the dpkg frontend lock (/var/lib/dpkg/lock-frontend), is another process using it?
make[1]: *** [Makefile:9: /sonic/target/debs/bullseye/openssh-server_8.4p1-5+deb11u1_amd64.deb] Error 100

liuh-80 · 2022-10-20T09:20:51Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2022-10-20T09:21:04Z

Azure Pipelines successfully started running 1 pipeline(s).

liuh-80 · 2022-10-21T02:08:02Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2022-10-21T02:08:15Z

Azure Pipelines successfully started running 1 pipeline(s).

liuh-80 · 2022-10-21T03:16:57Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2022-10-21T03:17:08Z

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft · 2022-10-21T18:47:50Z

rules/openssh.mk


 OPENSSH_SERVER = openssh-server_$(OPENSSH_VERSION)_$(CONFIGURED_ARCH).deb
 $(OPENSSH_SERVER)_SRC_PATH = $(SRC_PATH)/openssh
+$(OPENSSH_SERVER)_DEPENDS +=  $(LIBNL3_DEV) $(LIBNL_ROUTE3_DEV)


LIBNL_ROUTE3_DEV

Seem this fix is a valid fix, and has no relationship with the other PR 12447 .

I am worried about why this bug is not exposed before? Could you check previous build log and possible find a build bug?

@xumia please be aware of this issue.

LIBNL_ROUTE3_DEV

Seem this fix is a valid fix, and has no relationship with the other PR 12447 .

I am worried about why this bug is not exposed before? Could you check previous build log and possible find a build bug?

I checked the build log and not found build issue caused by this.
When build on local devbox or run a full build, in most case we build everything from source code, so the libnl will be build and install before openssh build.

Here is how this issue happen:
When build on azure pipeline, we are using cache, so when change openssh code, the libnl will not build because there is no code change, also libnl will not be installed from cache. then openssh will build break because missing package.

liuh-80 · 2022-10-26T03:13:34Z

Request this for 202205 branch, later there will be another PR depends on this also will request for 202205 branch:

#12447

…12327) Update openssh make file, add missing dependency to libnl. #### Why I did it Openssh indirectly depends on libnl. Another PR #12447 need add new patch to openssh, after adding new patch to openssh, PR build failed with libnl missing error. #### How I did it Update openssh make file, add missing dependency to libnl. #### How to verify it Pass all test case #### Which release branch to backport (provide reason below if selected)  - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 #### Description for the changelog Update openssh make file, add missing dependency to libnl. #### Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. #### Link to config_db schema for YANG module changes  #### A picture of a cute animal (not mandatory but encouraged)

Update openssh make file, add missing depency to libnl.

42836c4

liuh-80 changed the title ~~[openssh] Update openssh make file, add missing depency to libnl.~~ [openssh] Update openssh make file, add missing dependency to libnl. Oct 10, 2022

liuh-80 closed this Oct 10, 2022

liuh-80 reopened this Oct 19, 2022

liuh-80 mentioned this pull request Oct 21, 2022

[openssh] Export remote address to environment variable for TACACS authorization. #12447

Merged

7 tasks

Fix dpkg lock issue

92705a6

liuh-80 marked this pull request as ready for review October 21, 2022 07:13

liuh-80 requested review from lguohan, qiluo-msft and xumia as code owners October 21, 2022 07:13

qiluo-msft reviewed Oct 21, 2022

View reviewed changes

xumia approved these changes Oct 24, 2022

View reviewed changes

liuh-80 merged commit fff6808 into sonic-net:master Oct 24, 2022

liuh-80 added the Request for 202205 Branch label Oct 26, 2022

yxieca added the Included in 202205 Branch label Oct 27, 2022

Conversation

liuh-80 commented Oct 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

liuh-80 commented Oct 10, 2022

Uh oh!

liuh-80 commented Oct 20, 2022

Uh oh!

azure-pipelines bot commented Oct 20, 2022

Uh oh!

liuh-80 commented Oct 20, 2022

Uh oh!

liuh-80 commented Oct 20, 2022

Uh oh!

azure-pipelines bot commented Oct 20, 2022

Uh oh!

liuh-80 commented Oct 20, 2022

Uh oh!

azure-pipelines bot commented Oct 20, 2022

Uh oh!

liuh-80 commented Oct 20, 2022

Uh oh!

liuh-80 commented Oct 20, 2022

Uh oh!

azure-pipelines bot commented Oct 20, 2022

Uh oh!

liuh-80 commented Oct 21, 2022

Uh oh!

azure-pipelines bot commented Oct 21, 2022

Uh oh!

liuh-80 commented Oct 21, 2022

Uh oh!

azure-pipelines bot commented Oct 21, 2022

Uh oh!

qiluo-msft Oct 21, 2022

Choose a reason for hiding this comment

Uh oh!

qiluo-msft Oct 21, 2022

Choose a reason for hiding this comment

Uh oh!

liuh-80 Oct 24, 2022

Choose a reason for hiding this comment

Uh oh!

liuh-80 commented Oct 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

liuh-80 commented Oct 10, 2022 •

edited

Loading