Skip to content

[swss]: Fix missing comma in the ports.json.j2 file#1217

Merged
lguohan merged 1 commit intosonic-net:masterfrom
stcheng:comma
Dec 8, 2017
Merged

[swss]: Fix missing comma in the ports.json.j2 file#1217
lguohan merged 1 commit intosonic-net:masterfrom
stcheng:comma

Conversation

@stcheng
Copy link
Contributor

@stcheng stcheng commented Dec 8, 2017

Add J2 test case as well as a sample output

Signed-off-by: Shu0T1an ChenG [email protected]

- How to verify it
Run the pytest

- Description for the changelog
this issue was introduced here: #1207

@stcheng stcheng requested a review from rodnymolina December 8, 2017 02:02
rodnymolina
rodnymolina approved these changes Dec 8, 2017
View reviewed changes
dockers/docker-orchagent/ports.json.j2 Outdated
Copy link
Contributor

@rodnymolina rodnymolina Dec 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this one.

src/sonic-config-engine/tests/simple-sample-graph.xml Outdated
Copy link
Contributor

@rodnymolina rodnymolina Dec 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about mixing interfaces with and without "description" to make sure that our code/testcases can deal with both scenarios.

Copy link
Contributor Author

@stcheng stcheng Dec 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I'll remove two of them.

Copy link
Contributor Author

@stcheng stcheng Dec 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

[swss]: Fix missing comma in the ports.json.j2 file
6a4af89 
Add J2 test case as well as a sample output

Signed-off-by: Shu0T1an ChenG <[email protected]>
@lguohan lguohan merged commit 1859f53 into sonic-net:master Dec 8, 2017
@stcheng stcheng deleted the comma branch December 8, 2017 21:22
@dzhangalibaba dzhangalibaba mentioned this pull request Apr 20, 2020
Merged
@judyjoseph judyjoseph mentioned this pull request Apr 25, 2020
Merged
@jleveque jleveque mentioned this pull request Nov 7, 2020
Merged
@madhanmellanox madhanmellanox mentioned this pull request Nov 8, 2020
Closed
3 tasks
jleveque added a commit that referenced this pull request Nov 13, 2020
@jleveque
[sonic-py-swsssdk][sonic-snmpagent][sonic-utilities] Update submodules (
d0c7bd8 
#5849)

Submodule updates include the following commits. Also adding sonic-swsscommon build dependencies where necessary.

* src/sonic-py-swsssdk 1ea30d2...9d9f0c6 (1):
  > [SonicV2Connector] make decode_responses=True as default, so python2 application need no code change when migrated to python3(#93)

* src/sonic-snmpagent 6e4a796...57e54d9 (3):
  > Interact with Redis by str instead of bytes, migrate to SonicV2Connector with `decode_responses=True` (#171)
  > Add a test case for LLDP_LOC_CHASSIS.lldp_loc_man_addr has only one IPv6 address (#167)
  > [LLDP]: Update init_db to load global database config (#166)

* src/sonic-utilities acfa824...b693cf6 (11):
  > Remove SKU create pytest output directory before execution of the script (#1226)
  > [show][techsupport][multi-ASIC] Add support to collect tech support on multi ASIC platform (#1193)
  > [show] Fix `show ip bgp sum` (#1194)
  > [sonic_sku_create] Move tests from sonic-utilities-tests/ folder to tests/ folder (#1222)
  > Replace swsssdk.SonicV2Connector with swsscommon.SonicV2Connector (SWIG wrapper of C++ implementation) in production code (#1217)
  > Copy missing values from INIT_CFG to config_db as part of db_migration task (#1209)
  > [connect][clear] Support --devicename option for connect/clear line commands (#1214)
  > [consutil][show] Remove root need from show line command (#1218)
  > [Mellanox] SKU creator Tool (#1163)
  > SONiC installer - fix string formatting during image type check (#1197)
  > [show/fgnhg.py] Fix whitespace issues (#1211)
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request Jan 14, 2021
@rlhui
[vnet]: Fix continues warning messages after config reload (sonic-net…
65dbc2b 
…#1217)

Signed-off-by: Volodymyr Samotiy <[email protected]>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request Jan 14, 2021
@rlhui
[vnet]: Fix continues warning messages after config reload (sonic-net…
941b8fb 
…#1217)

Signed-off-by: Volodymyr Samotiy <[email protected]>
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
@jleveque @santhosh-kt
[sonic-py-swsssdk][sonic-snmpagent][sonic-utilities] Update submodules (
a1e3e10 
sonic-net#5849)

Submodule updates include the following commits. Also adding sonic-swsscommon build dependencies where necessary.

* src/sonic-py-swsssdk 1ea30d2...9d9f0c6 (1):
  > [SonicV2Connector] make decode_responses=True as default, so python2 application need no code change when migrated to python3(sonic-net#93)

* src/sonic-snmpagent 6e4a796...57e54d9 (3):
  > Interact with Redis by str instead of bytes, migrate to SonicV2Connector with `decode_responses=True` (sonic-net#171)
  > Add a test case for LLDP_LOC_CHASSIS.lldp_loc_man_addr has only one IPv6 address (sonic-net#167)
  > [LLDP]: Update init_db to load global database config (sonic-net#166)

* src/sonic-utilities acfa824...b693cf6 (11):
  > Remove SKU create pytest output directory before execution of the script (sonic-net#1226)
  > [show][techsupport][multi-ASIC] Add support to collect tech support on multi ASIC platform (sonic-net#1193)
  > [show] Fix `show ip bgp sum` (sonic-net#1194)
  > [sonic_sku_create] Move tests from sonic-utilities-tests/ folder to tests/ folder (sonic-net#1222)
  > Replace swsssdk.SonicV2Connector with swsscommon.SonicV2Connector (SWIG wrapper of C++ implementation) in production code (sonic-net#1217)
  > Copy missing values from INIT_CFG to config_db as part of db_migration task (sonic-net#1209)
  > [connect][clear] Support --devicename option for connect/clear line commands (sonic-net#1214)
  > [consutil][show] Remove root need from show line command (sonic-net#1218)
  > [Mellanox] SKU creator Tool (sonic-net#1163)
  > SONiC installer - fix string formatting during image type check (sonic-net#1197)
  > [show/fgnhg.py] Fix whitespace issues (sonic-net#1211)
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
@qiluo-msft
Replace swsssdk.SonicV2Connector with swsscommon.SonicV2Connector (SW…
0d49a85 
…IG wrapper of C++ implementation) in production code (sonic-net#1217)

**- What I did**
This is the following step for merging sonic-py-swsssdk into sonic-swss-common sonic-net/sonic-swss-common#387

**- How I did it**

**- How to verify it**
Unit test and tested in DUT

* Replace swsssdk.SonicV2Connector with swsscommon.SonicV2Connector (SWIG wrapper of C++ implementation) in production code
* Remove extra statement
* Move back the import to original place
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
[vnet]: Fix continues warning messages after config reload (sonic-net…
fb8b6a0 
…#1217)

Signed-off-by: Volodymyr Samotiy <[email protected]>
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Mar 10, 2023
@dprital
[202205][submodule] Advance sonic-sairedis pointer
5eabc29 
Update sonic-sairedis submodule pointer to include the following:
* 23ac336 Use new value of STATE_DB FAST_REBOOT entry ([sonic-net#1217](sonic-net/sonic-sairedis#1217))

Signed-off-by: dprital <[email protected]>
patrickmacarthur pushed a commit to patrickmacarthur/sonic-buildimage that referenced this pull request Aug 6, 2025
@yejianquan
Update cisco-8000.ini to 202405.1.2.10 release (sonic-net#1217)
6b7bcc3 
Signed-off-by: Anand Mehra [email protected]

Why I did it
Fixed gbsyncd syncd process crash with macsec enabled links

signed-off-by: [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svc-acs svc-acs svc-acs approved these changes

+1 more reviewer

@rodnymolina rodnymolina rodnymolina approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug 🐛

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stcheng @rodnymolina @svc-acs @lguohan