Use sha1sum instead of shasum for portability#1113
Merged
lguohan merged 1 commit intosonic-net:masterfrom Nov 3, 2017
Staphylo:makefile-sha1sum
Merged
Use sha1sum instead of shasum for portability#1113lguohan merged 1 commit intosonic-net:masterfrom Staphylo:makefile-sha1sum
lguohan merged 1 commit intosonic-net:masterfrom
Staphylo:makefile-sha1sum
Conversation
sha1sum is a better option to use since it is part of the coreutil package. shasum is owned by perl which might not always exist on the host system.
jleveque
approved these changes
Nov 3, 2017
daall
added a commit
to daall/sonic-buildimage
that referenced
this pull request
Nov 19, 2019
sairedis: * [SAI] Update SAI submodule to v1.5.1 (sonic-net#532) * Cleanup Makefile.am from BFN specific code (sonic-net#530) * [vs] Implement indices for debug counters in VS (sonic-net#531) * Enable FastReboot if we have key "FAST_REBOOT|system" in State db (sonic-net#529) * [flex_counter] Add sairedis support for drop counters (sonic-net#520) swss: * [orchagent] Add swss support for drop counters (sonic-net#1075) * [orchagent] warning fixes for 32bit arch compilation (sonic-net#1129) * [utilities] Create utility classes for interacting with flex counters (sonic-net#1093) * [portsorch] add support to set mac-address learning attribute on bridge-port (sonic-net#809) * Fix traceroute issue (sonic-net#1113) utilities: * Add CLI support for configurable drop counters (sonic-net#688) * Revert "SONiC Management Framework Release 1.0 (sonic-net#659)" (sonic-net#741) * SONiC Management Framework Release 1.0 (sonic-net#659) Signed-off-by: Danny Allen <[email protected]>
lguohan
pushed a commit
that referenced
this pull request
Nov 21, 2019
sairedis: * [SAI] Update SAI submodule to v1.5.1 (#532) * Cleanup Makefile.am from BFN specific code (#530) * [vs] Implement indices for debug counters in VS (#531) * Enable FastReboot if we have key "FAST_REBOOT|system" in State db (#529) * [flex_counter] Add sairedis support for drop counters (#520) swss: * [orchagent] Add swss support for drop counters (#1075) * [orchagent] warning fixes for 32bit arch compilation (#1129) * [utilities] Create utility classes for interacting with flex counters (#1093) * [portsorch] add support to set mac-address learning attribute on bridge-port (#809) * Fix traceroute issue (#1113) utilities: * Add CLI support for configurable drop counters (#688) * Revert "SONiC Management Framework Release 1.0 (#659)" (#741) * SONiC Management Framework Release 1.0 (#659) Signed-off-by: Danny Allen <[email protected]>
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
sairedis: * [SAI] Update SAI submodule to v1.5.1 (sonic-net#532) * Cleanup Makefile.am from BFN specific code (sonic-net#530) * [vs] Implement indices for debug counters in VS (sonic-net#531) * Enable FastReboot if we have key "FAST_REBOOT|system" in State db (sonic-net#529) * [flex_counter] Add sairedis support for drop counters (sonic-net#520) swss: * [orchagent] Add swss support for drop counters (sonic-net#1075) * [orchagent] warning fixes for 32bit arch compilation (sonic-net#1129) * [utilities] Create utility classes for interacting with flex counters (sonic-net#1093) * [portsorch] add support to set mac-address learning attribute on bridge-port (sonic-net#809) * Fix traceroute issue (sonic-net#1113) utilities: * Add CLI support for configurable drop counters (sonic-net#688) * Revert "SONiC Management Framework Release 1.0 (sonic-net#659)" (sonic-net#741) * SONiC Management Framework Release 1.0 (sonic-net#659) Signed-off-by: Danny Allen <[email protected]>
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
* Add commands to ensure that the ‘mac’ doesn’t change if an interface is enslaved to this master
lguohan
added a commit
that referenced
this pull request
Sep 13, 2020
* 4d69425 2020-09-12 | [utilities] Define Explicit Dependency On Ipaddress Package (#1113) (HEAD, origin/201811) [Guohan Lu] Signed-off-by: Guohan Lu <[email protected]>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
May 10, 2021
…t#1113) 201811 branch build fails without taking explicit dependency on ipaddress package. singed-off-by: Tamer Ahmed <[email protected]>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
May 20, 2025
…D automatically (sonic-net#1113) #### Why I did it src/sonic-sairedis ``` * e18530c - (HEAD -> 202412, origin/HEAD, origin/202412) Update SAI version to 1.16.1 (#54) (8 hours ago) [mramezani95] ``` #### How I did it #### How to verify it #### Description for the changelog
qiluo-msft
pushed a commit
that referenced
this pull request
Dec 4, 2025
…omatically (#24285) Why I did it src/sonic-swss-common * 7f1b50f - (HEAD -> master, origin/master, origin/HEAD) Revert "[sonic-db-cli] Add flag to make cli calls to container databases (#1070)" and #1111 (#1123) (5 hours ago) [Qi Luo] * 16a8a93 - [ci] Use 1ES agent pool to provide more disk when building swss. (#1121) (2 days ago) [Liu Shilong] * 7682785 - Revert "Fix risky unwrap(), expect(), and casting (#1113)" (#1118) (2 days ago) [Liu Shilong] * cf7c7f6 - Fix issue where namespace would not be read (#1111) (2 days ago) [Connor Roos] * d6ccff7 - Fix risky unwrap(), expect(), and casting (#1113) (4 days ago) [Qi Luo] * e67092c - Add PORT_SERDES_ATTR_ID_LIST to FLEX COUNTER DATABASE (#1099) (9 days ago) [Dhanasekar Rathinavel] * d2c8f2c - [ci] Migrate agent pool from sonicbld-1es to sonicso1ES-amd64 (#1101) (2 weeks ago) [Liu Shilong] * 4b86a77 - [dhcp_relay] sonic dhcp relay agent for IPv4 (#1017) (4 weeks ago) [Akshath TR] * 472a425 - SHlorch changes for EVPN MH feature (#1051) (5 weeks ago) [jayakj] * 7407a2e - Optimize memory usage by replacing the queue's underlying container with a list. (#1083) (7 weeks ago) [Hua Liu] * 130d8b6 - Add chassis db. (#1085) (7 weeks ago) [dypet] * 66e437a - Fix mocktests for buster builds (#1087) (8 weeks ago) [prabhataravind] * 32b14a4 - Update static database_config.json in swsscommon (#1086) (8 weeks ago) [prabhataravind] * c253917 - Add pop batch size support for ZMQ Consumer (#1084) (8 weeks ago) [Vivek] * 4fea06e - [sonic-db-cli] Add flag to make cli calls to container databases (#1070) (8 weeks ago) [Connor Roos]
hdwhdw
pushed a commit
to hdwhdw/sonic-buildimage
that referenced
this pull request
Dec 4, 2025
…omatically (sonic-net#24285) Why I did it src/sonic-swss-common * 7f1b50f - (HEAD -> master, origin/master, origin/HEAD) Revert "[sonic-db-cli] Add flag to make cli calls to container databases (sonic-net#1070)" and sonic-net#1111 (sonic-net#1123) (5 hours ago) [Qi Luo] * 16a8a93 - [ci] Use 1ES agent pool to provide more disk when building swss. (sonic-net#1121) (2 days ago) [Liu Shilong] * 7682785 - Revert "Fix risky unwrap(), expect(), and casting (sonic-net#1113)" (sonic-net#1118) (2 days ago) [Liu Shilong] * cf7c7f6 - Fix issue where namespace would not be read (sonic-net#1111) (2 days ago) [Connor Roos] * d6ccff7 - Fix risky unwrap(), expect(), and casting (sonic-net#1113) (4 days ago) [Qi Luo] * e67092c - Add PORT_SERDES_ATTR_ID_LIST to FLEX COUNTER DATABASE (sonic-net#1099) (9 days ago) [Dhanasekar Rathinavel] * d2c8f2c - [ci] Migrate agent pool from sonicbld-1es to sonicso1ES-amd64 (sonic-net#1101) (2 weeks ago) [Liu Shilong] * 4b86a77 - [dhcp_relay] sonic dhcp relay agent for IPv4 (sonic-net#1017) (4 weeks ago) [Akshath TR] * 472a425 - SHlorch changes for EVPN MH feature (sonic-net#1051) (5 weeks ago) [jayakj] * 7407a2e - Optimize memory usage by replacing the queue's underlying container with a list. (sonic-net#1083) (7 weeks ago) [Hua Liu] * 130d8b6 - Add chassis db. (sonic-net#1085) (7 weeks ago) [dypet] * 66e437a - Fix mocktests for buster builds (sonic-net#1087) (8 weeks ago) [prabhataravind] * 32b14a4 - Update static database_config.json in swsscommon (sonic-net#1086) (8 weeks ago) [prabhataravind] * c253917 - Add pop batch size support for ZMQ Consumer (sonic-net#1084) (8 weeks ago) [Vivek] * 4fea06e - [sonic-db-cli] Add flag to make cli calls to container databases (sonic-net#1070) (8 weeks ago) [Connor Roos]
kewei-arista
pushed a commit
to kewei-arista/sonic-buildimage
that referenced
this pull request
Dec 8, 2025
…omatically (sonic-net#24285) Why I did it src/sonic-swss-common * 7f1b50f - (HEAD -> master, origin/master, origin/HEAD) Revert "[sonic-db-cli] Add flag to make cli calls to container databases (sonic-net#1070)" and sonic-net#1111 (sonic-net#1123) (5 hours ago) [Qi Luo] * 16a8a93 - [ci] Use 1ES agent pool to provide more disk when building swss. (sonic-net#1121) (2 days ago) [Liu Shilong] * 7682785 - Revert "Fix risky unwrap(), expect(), and casting (sonic-net#1113)" (sonic-net#1118) (2 days ago) [Liu Shilong] * cf7c7f6 - Fix issue where namespace would not be read (sonic-net#1111) (2 days ago) [Connor Roos] * d6ccff7 - Fix risky unwrap(), expect(), and casting (sonic-net#1113) (4 days ago) [Qi Luo] * e67092c - Add PORT_SERDES_ATTR_ID_LIST to FLEX COUNTER DATABASE (sonic-net#1099) (9 days ago) [Dhanasekar Rathinavel] * d2c8f2c - [ci] Migrate agent pool from sonicbld-1es to sonicso1ES-amd64 (sonic-net#1101) (2 weeks ago) [Liu Shilong] * 4b86a77 - [dhcp_relay] sonic dhcp relay agent for IPv4 (sonic-net#1017) (4 weeks ago) [Akshath TR] * 472a425 - SHlorch changes for EVPN MH feature (sonic-net#1051) (5 weeks ago) [jayakj] * 7407a2e - Optimize memory usage by replacing the queue's underlying container with a list. (sonic-net#1083) (7 weeks ago) [Hua Liu] * 130d8b6 - Add chassis db. (sonic-net#1085) (7 weeks ago) [dypet] * 66e437a - Fix mocktests for buster builds (sonic-net#1087) (8 weeks ago) [prabhataravind] * 32b14a4 - Update static database_config.json in swsscommon (sonic-net#1086) (8 weeks ago) [prabhataravind] * c253917 - Add pop batch size support for ZMQ Consumer (sonic-net#1084) (8 weeks ago) [Vivek] * 4fea06e - [sonic-db-cli] Add flag to make cli calls to container databases (sonic-net#1070) (8 weeks ago) [Connor Roos]
mssonicbld
added a commit
that referenced
this pull request
Dec 16, 2025
…omatically (#24792) #### Why I did it src/sonic-swss-common ``` * 03c6777 - (HEAD -> master, origin/master, origin/HEAD) Opportunistically use a matching kernel version for building the modules (#1138) (2 days ago) [Saikrishna Arcot] * 41acbf8 - Ensure RedisPipeline dtor not to throw (#1115) (5 days ago) [Qi Luo] * e8a9592 - Reapply "Fix risky unwrap(), expect(), and casting (#1113)" (#1118) (#1124) (5 days ago) [Qi Luo] ``` #### How I did it #### How to verify it #### Description for the changelog
hdwhdw
pushed a commit
to hdwhdw/sonic-buildimage
that referenced
this pull request
Dec 18, 2025
…omatically (sonic-net#24792) #### Why I did it src/sonic-swss-common ``` * 03c6777 - (HEAD -> master, origin/master, origin/HEAD) Opportunistically use a matching kernel version for building the modules (sonic-net#1138) (2 days ago) [Saikrishna Arcot] * 41acbf8 - Ensure RedisPipeline dtor not to throw (sonic-net#1115) (5 days ago) [Qi Luo] * e8a9592 - Reapply "Fix risky unwrap(), expect(), and casting (sonic-net#1113)" (sonic-net#1118) (sonic-net#1124) (5 days ago) [Qi Luo] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Dawei Huang <[email protected]>
xwjiang-ms
pushed a commit
to xwjiang-ms/sonic-buildimage
that referenced
this pull request
Dec 22, 2025
…omatically (sonic-net#24285) Why I did it src/sonic-swss-common * 7f1b50f - (HEAD -> master, origin/master, origin/HEAD) Revert "[sonic-db-cli] Add flag to make cli calls to container databases (sonic-net#1070)" and sonic-net#1111 (sonic-net#1123) (5 hours ago) [Qi Luo] * 16a8a93 - [ci] Use 1ES agent pool to provide more disk when building swss. (sonic-net#1121) (2 days ago) [Liu Shilong] * 7682785 - Revert "Fix risky unwrap(), expect(), and casting (sonic-net#1113)" (sonic-net#1118) (2 days ago) [Liu Shilong] * cf7c7f6 - Fix issue where namespace would not be read (sonic-net#1111) (2 days ago) [Connor Roos] * d6ccff7 - Fix risky unwrap(), expect(), and casting (sonic-net#1113) (4 days ago) [Qi Luo] * e67092c - Add PORT_SERDES_ATTR_ID_LIST to FLEX COUNTER DATABASE (sonic-net#1099) (9 days ago) [Dhanasekar Rathinavel] * d2c8f2c - [ci] Migrate agent pool from sonicbld-1es to sonicso1ES-amd64 (sonic-net#1101) (2 weeks ago) [Liu Shilong] * 4b86a77 - [dhcp_relay] sonic dhcp relay agent for IPv4 (sonic-net#1017) (4 weeks ago) [Akshath TR] * 472a425 - SHlorch changes for EVPN MH feature (sonic-net#1051) (5 weeks ago) [jayakj] * 7407a2e - Optimize memory usage by replacing the queue's underlying container with a list. (sonic-net#1083) (7 weeks ago) [Hua Liu] * 130d8b6 - Add chassis db. (sonic-net#1085) (7 weeks ago) [dypet] * 66e437a - Fix mocktests for buster builds (sonic-net#1087) (8 weeks ago) [prabhataravind] * 32b14a4 - Update static database_config.json in swsscommon (sonic-net#1086) (8 weeks ago) [prabhataravind] * c253917 - Add pop batch size support for ZMQ Consumer (sonic-net#1084) (8 weeks ago) [Vivek] * 4fea06e - [sonic-db-cli] Add flag to make cli calls to container databases (sonic-net#1070) (8 weeks ago) [Connor Roos] Signed-off-by: xiaweijiang <[email protected]>
xwjiang-ms
pushed a commit
to xwjiang-ms/sonic-buildimage
that referenced
this pull request
Dec 22, 2025
…omatically (sonic-net#24792) #### Why I did it src/sonic-swss-common ``` * 03c6777 - (HEAD -> master, origin/master, origin/HEAD) Opportunistically use a matching kernel version for building the modules (sonic-net#1138) (2 days ago) [Saikrishna Arcot] * 41acbf8 - Ensure RedisPipeline dtor not to throw (sonic-net#1115) (5 days ago) [Qi Luo] * e8a9592 - Reapply "Fix risky unwrap(), expect(), and casting (sonic-net#1113)" (sonic-net#1118) (sonic-net#1124) (5 days ago) [Qi Luo] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: xiaweijiang <[email protected]>
jasonbridges
pushed a commit
to jasonbridges/sonic-buildimage
that referenced
this pull request
Jan 22, 2026
…omatically (sonic-net#24285) Why I did it src/sonic-swss-common * 7f1b50f - (HEAD -> master, origin/master, origin/HEAD) Revert "[sonic-db-cli] Add flag to make cli calls to container databases (sonic-net#1070)" and sonic-net#1111 (sonic-net#1123) (5 hours ago) [Qi Luo] * 16a8a93 - [ci] Use 1ES agent pool to provide more disk when building swss. (sonic-net#1121) (2 days ago) [Liu Shilong] * 7682785 - Revert "Fix risky unwrap(), expect(), and casting (sonic-net#1113)" (sonic-net#1118) (2 days ago) [Liu Shilong] * cf7c7f6 - Fix issue where namespace would not be read (sonic-net#1111) (2 days ago) [Connor Roos] * d6ccff7 - Fix risky unwrap(), expect(), and casting (sonic-net#1113) (4 days ago) [Qi Luo] * e67092c - Add PORT_SERDES_ATTR_ID_LIST to FLEX COUNTER DATABASE (sonic-net#1099) (9 days ago) [Dhanasekar Rathinavel] * d2c8f2c - [ci] Migrate agent pool from sonicbld-1es to sonicso1ES-amd64 (sonic-net#1101) (2 weeks ago) [Liu Shilong] * 4b86a77 - [dhcp_relay] sonic dhcp relay agent for IPv4 (sonic-net#1017) (4 weeks ago) [Akshath TR] * 472a425 - SHlorch changes for EVPN MH feature (sonic-net#1051) (5 weeks ago) [jayakj] * 7407a2e - Optimize memory usage by replacing the queue's underlying container with a list. (sonic-net#1083) (7 weeks ago) [Hua Liu] * 130d8b6 - Add chassis db. (sonic-net#1085) (7 weeks ago) [dypet] * 66e437a - Fix mocktests for buster builds (sonic-net#1087) (8 weeks ago) [prabhataravind] * 32b14a4 - Update static database_config.json in swsscommon (sonic-net#1086) (8 weeks ago) [prabhataravind] * c253917 - Add pop batch size support for ZMQ Consumer (sonic-net#1084) (8 weeks ago) [Vivek] * 4fea06e - [sonic-db-cli] Add flag to make cli calls to container databases (sonic-net#1070) (8 weeks ago) [Connor Roos]
jasonbridges
pushed a commit
to jasonbridges/sonic-buildimage
that referenced
this pull request
Jan 22, 2026
…omatically (sonic-net#24792) #### Why I did it src/sonic-swss-common ``` * 03c6777 - (HEAD -> master, origin/master, origin/HEAD) Opportunistically use a matching kernel version for building the modules (sonic-net#1138) (2 days ago) [Saikrishna Arcot] * 41acbf8 - Ensure RedisPipeline dtor not to throw (sonic-net#1115) (5 days ago) [Qi Luo] * e8a9592 - Reapply "Fix risky unwrap(), expect(), and casting (sonic-net#1113)" (sonic-net#1118) (sonic-net#1124) (5 days ago) [Qi Luo] ``` #### How I did it #### How to verify it #### Description for the changelog
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
…omatically (sonic-net#24285) Why I did it src/sonic-swss-common * 7f1b50f - (HEAD -> master, origin/master, origin/HEAD) Revert "[sonic-db-cli] Add flag to make cli calls to container databases (sonic-net#1070)" and sonic-net#1111 (sonic-net#1123) (5 hours ago) [Qi Luo] * 16a8a93 - [ci] Use 1ES agent pool to provide more disk when building swss. (sonic-net#1121) (2 days ago) [Liu Shilong] * 7682785 - Revert "Fix risky unwrap(), expect(), and casting (sonic-net#1113)" (sonic-net#1118) (2 days ago) [Liu Shilong] * cf7c7f6 - Fix issue where namespace would not be read (sonic-net#1111) (2 days ago) [Connor Roos] * d6ccff7 - Fix risky unwrap(), expect(), and casting (sonic-net#1113) (4 days ago) [Qi Luo] * e67092c - Add PORT_SERDES_ATTR_ID_LIST to FLEX COUNTER DATABASE (sonic-net#1099) (9 days ago) [Dhanasekar Rathinavel] * d2c8f2c - [ci] Migrate agent pool from sonicbld-1es to sonicso1ES-amd64 (sonic-net#1101) (2 weeks ago) [Liu Shilong] * 4b86a77 - [dhcp_relay] sonic dhcp relay agent for IPv4 (sonic-net#1017) (4 weeks ago) [Akshath TR] * 472a425 - SHlorch changes for EVPN MH feature (sonic-net#1051) (5 weeks ago) [jayakj] * 7407a2e - Optimize memory usage by replacing the queue's underlying container with a list. (sonic-net#1083) (7 weeks ago) [Hua Liu] * 130d8b6 - Add chassis db. (sonic-net#1085) (7 weeks ago) [dypet] * 66e437a - Fix mocktests for buster builds (sonic-net#1087) (8 weeks ago) [prabhataravind] * 32b14a4 - Update static database_config.json in swsscommon (sonic-net#1086) (8 weeks ago) [prabhataravind] * c253917 - Add pop batch size support for ZMQ Consumer (sonic-net#1084) (8 weeks ago) [Vivek] * 4fea06e - [sonic-db-cli] Add flag to make cli calls to container databases (sonic-net#1070) (8 weeks ago) [Connor Roos] Signed-off-by: Feng Pan <[email protected]>
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
…omatically (sonic-net#24792) #### Why I did it src/sonic-swss-common ``` * 03c6777 - (HEAD -> master, origin/master, origin/HEAD) Opportunistically use a matching kernel version for building the modules (sonic-net#1138) (2 days ago) [Saikrishna Arcot] * 41acbf8 - Ensure RedisPipeline dtor not to throw (sonic-net#1115) (5 days ago) [Qi Luo] * e8a9592 - Reapply "Fix risky unwrap(), expect(), and casting (sonic-net#1113)" (sonic-net#1118) (sonic-net#1124) (5 days ago) [Qi Luo] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Feng Pan <[email protected]>
dprital
pushed a commit
that referenced
this pull request
Mar 19, 2026
…omatically (#24792) #### Why I did it src/sonic-swss-common ``` * 03c6777 - (HEAD -> master, origin/master, origin/HEAD) Opportunistically use a matching kernel version for building the modules (#1138) (2 days ago) [Saikrishna Arcot] * 41acbf8 - Ensure RedisPipeline dtor not to throw (#1115) (5 days ago) [Qi Luo] * e8a9592 - Reapply "Fix risky unwrap(), expect(), and casting (#1113)" (#1118) (#1124) (5 days ago) [Qi Luo] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: dprital <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Replaced shasum by sha1sum.
sha1sum is a better option to use since it is part of the coreutil package.
shasum is owned by perl which might not always exist on the host system.
- How to verify it
Just run make. It should be the same as sha1 is standard.
- Description for the changelog
Use sha1sum instead of shasum for portability