Skip to content

[Arista]: Fix the udev waiting in networking start#1093

Merged
prsunny merged 2 commits intosonic-net:masterfrom
byu343:master
Oct 31, 2017
Merged

[Arista]: Fix the udev waiting in networking start#1093
prsunny merged 2 commits intosonic-net:masterfrom
byu343:master

Conversation

@byu343
Copy link
Copy Markdown
Contributor

@byu343 byu343 commented Oct 30, 2017

This change is to fix the issue in aristanetworks/sonic#16
We noticed that the long waiting time in service networking start is because the original 'udevadm settle' waits for some irrelevant devices. By the change, only eth0 is waited for.
For the checking condition used, this change is only applied to Arista switches

Signed-off-by: Boyang Yu byu@arista.com

This change is to fix the issue in aristanetworks/sonic#16
For the checking condition used, it is only applied to Arista switches

Signed-off-by: Boyang Yu <byu@arista.com>
@prsunny
Copy link
Copy Markdown
Contributor

prsunny commented Oct 30, 2017

I took this change and compiled but showing a permission denied issue while building "aboot" image in my VM. Just want to ensure this doesn't happen in release build.

Logs:

  • '[' aboot = aboot ']'
  • sed -i 's/udevadm settle/udevadm settle -E /sys/class/net/eth0/' ./fsroot/etc/init.d/networking
    sed: couldn't open temporary file ./fsroot/etc/init.d/sedpzcvcA: Permission denied

Signed-off-by: Boyang Yu <byu@arista.com>
@prsunny
Copy link
Copy Markdown
Contributor

prsunny commented Oct 30, 2017

Changes looks good. I compiled it in my local repo and tested on A7060. eth0 is coming up as soon as logged in.

@prsunny prsunny self-requested a review October 30, 2017 23:09
@prsunny prsunny merged commit d7d6c41 into sonic-net:master Oct 31, 2017
daall added a commit to daall/sonic-buildimage that referenced this pull request Nov 19, 2019
sairedis:
* [SAI] Update SAI submodule to v1.5.1 (sonic-net#532)
* Cleanup Makefile.am from BFN specific code (sonic-net#530)
* [vs] Implement indices for debug counters in VS (sonic-net#531)
* Enable FastReboot if we have key "FAST_REBOOT|system" in State db (sonic-net#529)
* [flex_counter] Add sairedis support for drop counters (sonic-net#520)

swss:
* [orchagent] Add swss support for drop counters (sonic-net#1075)
* [orchagent] warning fixes for 32bit arch compilation (sonic-net#1129)
* [utilities] Create utility classes for interacting with flex counters (sonic-net#1093)
* [portsorch] add support to set mac-address learning attribute on bridge-port (sonic-net#809)
* Fix traceroute issue (sonic-net#1113)

utilities:
* Add CLI support for configurable drop counters (sonic-net#688)
* Revert "SONiC Management Framework Release 1.0 (sonic-net#659)" (sonic-net#741)
* SONiC Management Framework Release 1.0 (sonic-net#659)

Signed-off-by: Danny Allen <daall@microsoft.com>
lguohan pushed a commit that referenced this pull request Nov 21, 2019
sairedis:
* [SAI] Update SAI submodule to v1.5.1 (#532)
* Cleanup Makefile.am from BFN specific code (#530)
* [vs] Implement indices for debug counters in VS (#531)
* Enable FastReboot if we have key "FAST_REBOOT|system" in State db (#529)
* [flex_counter] Add sairedis support for drop counters (#520)

swss:
* [orchagent] Add swss support for drop counters (#1075)
* [orchagent] warning fixes for 32bit arch compilation (#1129)
* [utilities] Create utility classes for interacting with flex counters (#1093)
* [portsorch] add support to set mac-address learning attribute on bridge-port (#809)
* Fix traceroute issue (#1113)

utilities:
* Add CLI support for configurable drop counters (#688)
* Revert "SONiC Management Framework Release 1.0 (#659)" (#741)
* SONiC Management Framework Release 1.0 (#659)

Signed-off-by: Danny Allen <daall@microsoft.com>
zhenggen-xu pushed a commit to zhenggen-xu/sonic-buildimage that referenced this pull request Jan 10, 2020
sairedis:
* [SAI] Update SAI submodule to v1.5.1 (sonic-net#532)
* Cleanup Makefile.am from BFN specific code (sonic-net#530)
* [vs] Implement indices for debug counters in VS (sonic-net#531)
* Enable FastReboot if we have key "FAST_REBOOT|system" in State db (sonic-net#529)
* [flex_counter] Add sairedis support for drop counters (sonic-net#520)

swss:
* [orchagent] Add swss support for drop counters (sonic-net#1075)
* [orchagent] warning fixes for 32bit arch compilation (sonic-net#1129)
* [utilities] Create utility classes for interacting with flex counters (sonic-net#1093)
* [portsorch] add support to set mac-address learning attribute on bridge-port (sonic-net#809)
* Fix traceroute issue (sonic-net#1113)

utilities:
* Add CLI support for configurable drop counters (sonic-net#688)
* Revert "SONiC Management Framework Release 1.0 (sonic-net#659)" (sonic-net#741)
* SONiC Management Framework Release 1.0 (sonic-net#659)

Signed-off-by: Danny Allen <daall@microsoft.com>
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
…sonic-net#1093)

* [utilities] Create utility classes for interacting with flex counters
- Adds utility classes for interacting with flex counters
- Updates makefiles to support new utilities

Signed-off-by: Danny Allen <daall@microsoft.com>

* Reorganize helper classes

* Respond to PR feedback

* Fix stray includes

* Strip comma from end of string instead of beginning

* Fix build issue

* Fix style issues

* Add workaround for flex counter behavior
richardyu-ms added a commit to richardyu-ms/sonic-buildimage that referenced this pull request Jul 27, 2022
Upgrade submodule sairedis to take the fix for saithrift build
Upgrade SAI to latest for building in bullseye (sonic-net#1093)

involve other changes in sairedis:
[sairedis] Fix reopen recoding file (sonic-net#1087)
Update PN with XPN support (sonic-net#1081)
[syncd] Remove error message when tryTranslateVidToRid fails (sonic-net#1048)

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
@richardyu-ms richardyu-ms mentioned this pull request Jul 27, 2022
7 tasks
lguohan pushed a commit that referenced this pull request Jul 28, 2022
Upgrade submodule sairedis to take the fix for saithrift build
Upgrade SAI to latest for building in bullseye (#1093)

involve other changes in sairedis:
[sairedis] Fix reopen recoding file (#1087)
Update PN with XPN support (#1081)
[syncd] Remove error message when tryTranslateVidToRid fails (#1048)

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Sep 23, 2022
[submodule]: update sairedis (sonic-net#11545)

Upgrade submodule sairedis to take the fix for saithrift build
Upgrade SAI to latest for building in bullseye (sonic-net#1093)

involve other changes in sairedis:
[sairedis] Fix reopen recoding file (sonic-net#1087)
Update PN with XPN support (sonic-net#1081)
[syncd] Remove error message when tryTranslateVidToRid fails (sonic-net#1048)

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
dgsudharsan pushed a commit to dgsudharsan/sonic-buildimage that referenced this pull request May 12, 2025
<!--
Please make sure you've read and understood our contributing guidelines:
     https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

** Make sure all your commits include a signature generated with `git
commit -s` **

If this is a bug fix, make sure your description includes "fixes #xxxx",
or
     "closes #xxxx" or "resolves #xxxx"

     Please provide the following information:
-->

#### Why I did it
bring sonic-bmp as submodule of sonic-buildimage-msft repo


##### Work item tracking
- Microsoft ADO **(number only)**:27588893

#### How I did it
update submodule


#### How to verify it
git cmd

<!--
If PR needs to be backported, then the PR must be tested against the
base branch and the earliest backport release branch and provide tested
image version on these two branches. For example, if the PR is requested
for master, 202211 and 202012, then the requester needs to provide test
results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
Ensure to add label/tag for the feature raised. example - PR#2174 under
sonic-utilities repo. where, Generic Config and Update feature has been
labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants