Update RSyslog HLD with new functionality#1218
Conversation
|
|
iavraham
changed the title
doc/syslog/syslog-design.md
Outdated
There was a problem hiding this comment.
We need to get rid of section numbers here and remove them from table of content.
You can use "<!-- omit in toc -->" directive. See here
doc/syslog/syslog-design.md
Outdated
There was a problem hiding this comment.
Suggest to update the description.
The server address represents either an IP address or a DNS domain name.
doc/syslog/syslog-design.md
Outdated
There was a problem hiding this comment.
Can we add a default 'standard' field?
|
@dharmaraj-gurusamy wants to be the reviewer. |
doc/syslog/syslog-design.md
Outdated
There was a problem hiding this comment.
The original document has this as title & Introduction is marked as section 1. All section numbers seems incremented. Please correct the document headers.
doc/syslog/syslog-design.md
Outdated
There was a problem hiding this comment.
Please add short note about the extended capabilities.
There was a problem hiding this comment.
added detailed description
doc/syslog/syslog-design.md
Outdated
There was a problem hiding this comment.
severity will be a better name as trap may confuse with SNMP terminology. Please keep uniform name for both global & server specific configuration parameters.
There was a problem hiding this comment.
we defined this name in our internal usage so we would prefer to leave it like that.
is it acceptable by you?
There was a problem hiding this comment.
The man page (https://www.rsyslog.com/doc/v8-stable/configuration/filters.html) states priority / severity term. Hence, I would still recommend to rename either as severity / priority for better conveying the purpose.
doc/syslog/syslog-design.md
Outdated
There was a problem hiding this comment.
Please share more details on this statement, preferably with an example.
doc/syslog/syslog-design.md
Outdated
There was a problem hiding this comment.
The extended parameters shall be displayed in show command output also for consistency.
doc/syslog/syslog-design.md
Outdated
There was a problem hiding this comment.
filter_type will be the better name.
doc/syslog/syslog-design.md
Outdated
There was a problem hiding this comment.
severity will be the better name.
doc/syslog/syslog-design.md
Outdated
There was a problem hiding this comment.
Please add the default value.
doc/syslog/syslog-design.md
Outdated
There was a problem hiding this comment.
Will the default values be added in redis during upgrade scenarios (db_migrator script)? If not, we might end up in inconsistency after upgrade?
There was a problem hiding this comment.
if the keys are empty we will use the global default value in the template
doc/syslog/syslog-design.md
Outdated
There was a problem hiding this comment.
The man page (https://www.rsyslog.com/doc/v8-stable/configuration/filters.html) states priority / severity term. Hence, I would still recommend to rename either as severity / priority for better conveying the purpose.
|
to merge the submodules, we first need to merge sonic-swss-common and then we can pass CI tests |
|
@iavraham any time line when feature can be approved and merged? Thank you! |
We answered/closed all comments in this PR. Now we are waiting for maintainers to approve and merge it. |
|
Will review before 5/25 |
doc/syslog/syslog-design.md
Outdated
There was a problem hiding this comment.
Current 'show runningconfiguration syslog' is matching lines starting with '.'.
Will it break the show cli function? https://github.com/sonic-net/sonic-utilities/blob/master/show/main.py#L1687
There was a problem hiding this comment.
Will it break the show cli function?
It will. I fixed it here: sonic-net/sonic-utilities#2843
fastiuk
force-pushed
the
rsyslog_hld_update
branch
from
3b29864 to
cd54a88
Compare
fastiuk
force-pushed
the
rsyslog_hld_update
branch
from
e632798 to
f96a9f1
Compare
8 participants
Adding the following functionality:
these are the implementation PRs for community review: