Conversation
|
@iavraham Please update the description of this PR. What are the changes that are being introduced? |
| | Rev | Date | Author | Description | | ||
| |:---:|:----------:|:--------------:|:----------------------| | ||
| | 0.1 | 18/04/2022 | Nazarii Hnydyn | Initial version | | ||
| | 0.2 | 08/01/2022 | Ido Avraham | extend capabilities | |
| **This feature will support the following commands:** | ||
| 1. config: add/delete syslog server configuration | ||
| 2. show: display syslog server configuration | ||
| 3. config: set/unset global syslog configuration |
There was a problem hiding this comment.
3 & 4 is for regex and severity filtering?
There was a problem hiding this comment.
no, it's for global syslog changes.
for the global (default) severity and message format
|
|
||
| #### 3.4.1.1. Global syslog table | ||
| ```abnf | ||
| ; define schema for syslog global configuration attributes under SYSLOG_CONFIG|GLOBAL |
There was a problem hiding this comment.
Is this config going to affect the local syslog? The patterns applied here are going to suppress logs at local device. Is thet correct?
There was a problem hiding this comment.
No, it is not. The new configuration presented in this table is only for sending logs to remote syslog server.
| | port | port | SYSLOG_SERVER\|key\|port | | ||
| | vrf | device | SYSLOG_SERVER\|key\|vrf | | ||
| | protocol | protocol | SYSLOG_SERVER\|key\|protocol | | ||
| | filter | ereregex | SYSLOG_SERVER\|key\|filter | |
There was a problem hiding this comment.
filter values should be include/exclude right? The filter_pattern should be ereregex.
There was a problem hiding this comment.
correct, but from what i understood this table indicates the related parameter in the rsyslogd config file and this is why i wrote eregex. there is no include/exclude field there. it controls the "!" before eregrex field.
do you want me to change it?
| ; field = value | ||
| format = template-format ; template to send logs | ||
| welf_firewall_name = template | ||
| trap = log-level |
There was a problem hiding this comment.
If this is for local syslog, should we rename this field loglevel instead of trap?
There was a problem hiding this comment.
As it was mentioned in previous comment, it is only for sending to remote
| ``` | ||
|
|
||
| ### 2.4.3 Configuration sample | ||
| 7) "protocol" |
There was a problem hiding this comment.
Please provide configuration example for SYSLOG_CONFIG
| @@ -430,10 +634,14 @@ _config syslog add_ | |||
| 1. `-s|--source` - source ip address | |||
There was a problem hiding this comment.
Are we planning to add config commands for SYSLOG_CONFIG too?
There was a problem hiding this comment.
As we discussed, define new CLI that can be added to sonic, but we won’t implement it as part of the push of the feature
| leaf server_address { | ||
| description "Syslog server IP address"; | ||
| type inet:ip-address; | ||
| type inet:host; |
There was a problem hiding this comment.
By this change it also makes the ip address that can be configured using domain name. Is that correct? Please update other locations in this file too
There was a problem hiding this comment.
it is correct, there are no other places in the file that needs to be changed
|
creating public pull request |
|
@dgsudharsan Ido updated HLD according to your comments and created public PR. |
3 participants
rsyslog HLD update