Skip to content

Fix missing begin event on Android for Pinch and Rotation #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j-piasecki merged 2 commits into from
Oct 21, 2022
Merged

Fix missing begin event on Android for Pinch and Rotation #2264

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3be902c
Fix missing `begin` event
j-piasecki Oct 10, 2022
edf133c
Merge branch 'main' into @jpiasecki/fix-pinch-rotation-begin-event
j-piasecki Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions android/lib/src/main/java/com/swmansion/gesturehandler/PinchGestureHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ class PinchGestureHandler : GestureHandler<PinchGestureHandler>() {
scaleGestureDetector = ScaleGestureDetector(context, gestureListener)
val configuration = ViewConfiguration.get(context)
spanSlop = configuration.scaledTouchSlop.toFloat()

// set the focal point to the position of the first pointer as NaN causes the event not to arrive
this.focalPointX = event.x
this.focalPointY = event.y

begin()
}
scaleGestureDetector?.onTouchEvent(sourceEvent)
Expand Down
5 changes: 5 additions & 0 deletions android/lib/src/main/java/com/swmansion/gesturehandler/RotationGestureHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ class RotationGestureHandler : GestureHandler<RotationGestureHandler>() {
if (state == STATE_UNDETERMINED) {
resetProgress()
rotationGestureDetector = RotationGestureDetector(gestureListener)

// set the anchor to the position of the first pointer as NaN causes the event not to arrive
this.anchorX = event.x
this.anchorY = event.y

begin()
}
rotationGestureDetector?.onTouchEvent(sourceEvent)
Expand Down