Fix missing begin event on Android for Pinch and Rotation
#2264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukmccall
added a commit
to expo/expo
that referenced
this pull request
Oct 20, 2022
# Why It is connected with software-mansion/react-native-gesture-handler#2264. # How Applied unpublished path from the gesture handler repository. # Test Plan - expo-go with NCL ✅
m-bert
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR sets the focal point/anchor to the position of the pointer before sending
beginevent on Android. At the position it's being sent, it's alwaysNaNat the moment, which causes the event not to be received by the detector.Test plan
Add pinch & rotation gestures to the app and check whether the
beginevent is called.