Skip to content

Conversation

@alaneuler
Copy link
Contributor

fix: #671
fix: #674

Copy link
Contributor

@glmapper glmapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #675 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #675      +/-   ##
============================================
- Coverage     51.21%   51.18%   -0.04%     
  Complexity       87       87              
============================================
  Files           276      276              
  Lines          7972     7977       +5     
  Branches       1128     1131       +3     
============================================
  Hits           4083     4083              
  Misses         3441     3441              
- Partials        448      453       +5     
Impacted Files Coverage Δ Complexity Δ
...lthcheck/AfterReadinessCheckCallbackProcessor.java 87.75% <100.00%> (+1.39%) 0.00 <0.00> (ø)
...m/alipay/sofa/isle/stage/ModuleLogOutputStage.java 84.76% <0.00%> (-3.81%) 0.00% <0.00%> (ø%)
...ime/component/impl/StandardSofaRuntimeManager.java 71.69% <0.00%> (-1.89%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b7960c...beff4c1. Read the comment docs.

@alaneuler alaneuler merged commit 3be5a73 into sofastack:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Readiness callback invoking should be break when there is failure happening readme 改进

3 participants