Skip to content

Release 4.6.0 #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CrazyHZM merged 1 commit into from
Nov 24, 2025
Merged

Release 4.6.0 #1395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ jobs:
- name: Build with Maven
run: mvn --batch-mode deploy -DskipTests -Prelease
env:
MAVEN_USERNAME: ${{ secrets.NEW_MAVEN_USERNAME }}
MAVEN_PASSWORD: ${{ secrets.NEW_MAVEN_PASSWORD }}
MAVEN_USERNAME: ${{ secrets.MAVEN_USERNAME }}
MAVEN_PASSWORD: ${{ secrets.MAVEN_PASSWORD }}
Comment on lines +29 to +30
Copy link

@coderabbitai coderabbitai bot Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

❓ Verification inconclusive

Verify GitHub Secrets are configured with the new credential names.

The workflow now references MAVEN_USERNAME and MAVEN_PASSWORD secrets (lines 29–30). If these secrets are not defined in the GitHub repository, the mvn deploy step will fail with authentication errors.

Please verify:

  1. That your GitHub repository has secrets named MAVEN_USERNAME and MAVEN_PASSWORD configured
  2. That these secrets contain the correct credentials for OSS Sonatype Maven Central deployment
  3. That the old secret names (NEW_MAVEN_USERNAME, NEW_MAVEN_PASSWORD) are no longer referenced elsewhere in CI workflows

Run the following script to search for any remaining references to the old secret names in the repository:

🏁 Script executed:

#!/bin/bash
# Search for references to old secret names in workflow files
rg -i "NEW_MAVEN_USERNAME|NEW_MAVEN_PASSWORD" .github/workflows/

Length of output: 0

Verify GitHub Secrets are configured with the new credential names.

The workflow now references MAVEN_USERNAME and MAVEN_PASSWORD secrets (lines 29–30). The script confirmed no remaining references to the old secret names (NEW_MAVEN_USERNAME, NEW_MAVEN_PASSWORD) exist in the workflows directory.

However, the workflow will fail if these secrets are not defined in your GitHub repository settings.

Please verify in your GitHub repository settings:

  1. That secrets named MAVEN_USERNAME and MAVEN_PASSWORD are configured
  2. That these secrets contain the correct credentials for OSS Sonatype Maven Central deployment
🤖 Prompt for AI Agents 
.github/workflows/release.yml around lines 29-30: the workflow now references
secrets MAVEN_USERNAME and MAVEN_PASSWORD but will fail if they are not defined;
go to the repository Settings → Secrets and variables → Actions and ensure two
secrets named exactly MAVEN_USERNAME and MAVEN_PASSWORD exist and contain the
correct OSS Sonatype Maven Central credentials (username and password) used by
your publishing step; if your org requires different secret names, either create
these two secrets or update the workflow to match the existing secret names,
then commit the change.

MAVEN_GPG_PASSPHRASE: ${{ secrets.MAVEN_GPG_PASSPHRASE }}
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
<description>SOFABoot Build</description>

<properties>
<revision>4.6.0-SNAPSHOT</revision>
<revision>4.6.0</revision>
<sofa.boot.version>${revision}</sofa.boot.version>
<spring.boot.version>3.5.6</spring.boot.version>
<!--project-->
Expand Down
Loading