-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Release 4.6.0 #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 4.6.0 #1395
Conversation
Signed-off-by: JermaineHua <[email protected]>
WalkthroughThe pull request updates two configuration files. The GitHub Actions release workflow is modified to reference different Maven credential secrets, changing from Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/release.yml(1 hunks)pom.xml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: build (17)
- GitHub Check: build (25-ea)
- GitHub Check: build (21)
- GitHub Check: sca
🔇 Additional comments (1)
pom.xml (1)
38-38: Version bump to release version is correct.The revision property change from
4.6.0-SNAPSHOTto4.6.0is the appropriate step for transitioning to a release version. The flatten-maven-plugin configuration will properly resolve this CI-friendly version property during the build.
| MAVEN_USERNAME: ${{ secrets.MAVEN_USERNAME }} | ||
| MAVEN_PASSWORD: ${{ secrets.MAVEN_PASSWORD }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Verification inconclusive
Verify GitHub Secrets are configured with the new credential names.
The workflow now references MAVEN_USERNAME and MAVEN_PASSWORD secrets (lines 29–30). If these secrets are not defined in the GitHub repository, the mvn deploy step will fail with authentication errors.
Please verify:
- That your GitHub repository has secrets named
MAVEN_USERNAMEandMAVEN_PASSWORDconfigured - That these secrets contain the correct credentials for OSS Sonatype Maven Central deployment
- That the old secret names (
NEW_MAVEN_USERNAME,NEW_MAVEN_PASSWORD) are no longer referenced elsewhere in CI workflows
Run the following script to search for any remaining references to the old secret names in the repository:
🏁 Script executed:
#!/bin/bash
# Search for references to old secret names in workflow files
rg -i "NEW_MAVEN_USERNAME|NEW_MAVEN_PASSWORD" .github/workflows/Length of output: 0
Verify GitHub Secrets are configured with the new credential names.
The workflow now references MAVEN_USERNAME and MAVEN_PASSWORD secrets (lines 29–30). The script confirmed no remaining references to the old secret names (NEW_MAVEN_USERNAME, NEW_MAVEN_PASSWORD) exist in the workflows directory.
However, the workflow will fail if these secrets are not defined in your GitHub repository settings.
Please verify in your GitHub repository settings:
- That secrets named
MAVEN_USERNAMEandMAVEN_PASSWORDare configured - That these secrets contain the correct credentials for OSS Sonatype Maven Central deployment
🤖 Prompt for AI Agents
.github/workflows/release.yml around lines 29-30: the workflow now references
secrets MAVEN_USERNAME and MAVEN_PASSWORD but will fail if they are not defined;
go to the repository Settings → Secrets and variables → Actions and ensure two
secrets named exactly MAVEN_USERNAME and MAVEN_PASSWORD exist and contain the
correct OSS Sonatype Maven Central credentials (username and password) used by
your publishing step; if your org requires different secret names, either create
these two secrets or update the workflow to match the existing secret names,
then commit the change.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1395 +/- ##
============================================
+ Coverage 82.93% 82.94% +0.01%
- Complexity 2973 2975 +2
============================================
Files 340 340
Lines 9833 9833
Branches 1178 1178
============================================
+ Hits 8155 8156 +1
+ Misses 1164 1163 -1
Partials 514 514 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.