Skip to content

fix(sharded): private room broadcast in dynamic mode #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darrachequesne merged 2 commits into from
Mar 13, 2024
Merged

fix(sharded): private room broadcast in dynamic mode #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fcf611
fix(sharded): private room broadcast in dynamic mode
MartinKolarik Feb 13, 2024
fbf17ed
fix: works with io.to(specificId).emit
darrachequesne Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/sharded-adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ import debugModule from "debug";

const debug = debugModule("socket.io-redis");

function looksLikeASocketId(room: any) {
return typeof room === "string" && room.length === 20;
}

export interface ShardedRedisAdapterOptions {
/**
* The prefix for the Redis Pub/Sub channels.
Expand Down Expand Up @@ -128,7 +132,8 @@ class ShardedRedisAdapter extends ClusterAdapter {
this.opts.subscriptionMode === "dynamic" &&
message.type === MessageType.BROADCAST &&
message.data.requestId === undefined &&
message.data.opts.rooms.length === 1;
message.data.opts.rooms.length === 1 &&
!looksLikeASocketId(message.data.opts.rooms[0]);
if (useDynamicChannel) {
return this.dynamicChannel(message.data.opts.rooms[0]);
} else {
Expand Down
8 changes: 8 additions & 0 deletions test/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,14 @@ export function testSuite(createAdapter: any) {
servers[0].local.emit("test");
});

it("broadcasts to a single client", (done) => {
clientSockets[0].on("test", shouldNotHappen(done));
clientSockets[1].on("test", () => done());
clientSockets[2].on("test", shouldNotHappen(done));

servers[0].to(serverSockets[1].id).emit("test");
});

it("broadcasts with multiple acknowledgements", (done) => {
clientSockets[0].on("test", (cb) => cb(1));
clientSockets[1].on("test", (cb) => cb(2));
Expand Down