fix(sharded): private room broadcast in dynamic mode#525
Merged
darrachequesne merged 2 commits intosocketio:mainfrom Mar 13, 2024
Merged
fix(sharded): private room broadcast in dynamic mode#525darrachequesne merged 2 commits intosocketio:mainfrom
darrachequesne merged 2 commits intosocketio:mainfrom
Conversation
This was referenced Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #524 by adding a check for
expectSingleResponseflag, which is added forRemoteSocketinstances here. I couldn't find any documentation about that flag, but it seems to be the only way of identifying this case and it does fix the problem.