fix(provider): preserve @cf model identifiers#1701
Open
Alix-007 wants to merge 1 commit intosipeed:mainfrom
Open
fix(provider): preserve @cf model identifiers#1701Alix-007 wants to merge 1 commit intosipeed:mainfrom
Alix-007 wants to merge 1 commit intosipeed:mainfrom
Conversation
Contributor
Author
|
Retained PR is still green: Security Check / Linter / Tests / license/cla all passed on the head. Ready for maintainer review when there is capacity to reconcile the provider fallback ID regression. |
Contributor
Author
|
Retained PR is still green: Security Check / Linter / Tests / license/cla all passed on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cloudflare AI model IDs such as
@cf/qwen/qwen1.5-0.5b-chatcontain slashes that belong to the model path. PicoClaw was treating the first slash as a provider separator, which broke both provider creation and model-reference parsing.This change treats
@...model IDs as bare model identifiers, preserving the full string while still using the default OpenAI-compatible provider path.Type of Change
AI Code Generation
Related Issue
Fixes #1165
Technical Context
@cf/...intact inExtractProtocol@cf/...intact inParseModelRefTest Environment
Evidence
go test ./pkg/providersChecklist