Skip to content

fix(provider): preserve @cf model identifiers#1398

Closed
Alix-007 wants to merge 5 commits intosipeed:mainfrom
Alix-007:fix/issue-1165-atcf-model-id
Closed

fix(provider): preserve @cf model identifiers#1398
Alix-007 wants to merge 5 commits intosipeed:mainfrom
Alix-007:fix/issue-1165-atcf-model-id

Conversation

@Alix-007
Copy link
Copy Markdown
Contributor

Fixes #1165.

  • treat Cloudflare @cf/... IDs as model paths, not protocol prefixes
  • preserve the full model string in provider parsing and model refs
  • add regression tests for CreateProviderFromConfig and ParseModelRef

@sipeed-bot sipeed-bot bot added type: bug Something isn't working domain: provider go Pull requests that update go code labels Mar 12, 2026
xuwei-xy pushed a commit to xuwei-xy/picoclaw that referenced this pull request Mar 14, 2026
@Alix-007
Copy link
Copy Markdown
Contributor Author

Follow-up update: I pushed a forward-only sync commit so the Cloudflare model-ID fix now sits on top of the current provider matrix (azure, anthropic_messages, common, and protocoltypes). Local validation on this branch: go test ./pkg/providers -run TestExtractProtocol -count=1, go test ./pkg/providers -run TestCreateProviderFromConfig_CloudflareModelID -count=1, go test ./pkg/providers -run TestCreateProviderFromConfig_ModelScope -count=1, go test ./pkg/providers -run TestCreateProviderFromConfig_Azure -count=1, go test ./pkg/providers -run TestGetDefaultAPIBase_ModelScope -count=1, plus go test for ./pkg/providers/anthropic_messages, ./pkg/providers/azure, and ./pkg/providers/common.

@Alix-007
Copy link
Copy Markdown
Contributor Author

Pushed a follow-up that moves the Cloudflare coverage away from the same insertion point as the new Azure cases. Local checks passed with:

  • go test ./pkg/providers -run TestExtractProtocol -count=1
  • go test ./pkg/providers -run TestCreateProviderFromConfig_CloudflareModelID -count=1
    I also re-ran a local merge probe against upstream/main and it now merges cleanly.

@Alix-007
Copy link
Copy Markdown
Contributor Author

Superseded by #1701, which rebases the same @cf model-id preservation fix onto current main and now has a green PR workflow.

@Alix-007 Alix-007 closed this Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: provider go Pull requests that update go code type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Model name is not taken

1 participant