Delete temporary mitigation for equivocation via RPC

[michaelsproul]

Issue Addressed

Delete the temporary workaround introduced in #4179 for the "RPC unbundling attack" described here: https://lighthouse-blog.sigmaprime.io/mev-unbundling-rpc.html. We no longer need the workaround due to the fork choice patch specced in ethereum/consensus-specs#3352 and implemented in #4735.

Proposed Changes

Delete the requeueing for equivocating blocks received via RPC. Now we will process them immediately without any risk of overriding a previously seen (slashable) block at the same slot.

[dapplion]

For reference the FC patch is here

lighthouse/consensus/fork_choice/src/fork_choice.rs

Lines 726 to 729 in 1427339

	let is_first_block = self.fc_store.proposer_boost_root().is_zero();
	if current_slot == block.slot() && is_before_attesting_interval && is_first_block {
	self.fc_store.set_proposer_boost_root(block_root);
	}

Merged into sigp:deneb-free-blobs on Sep 25, 2023

[michaelsproul]

@Mergifyio queue

[mergify]

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

[michaelsproul]

@Mergifyio requeue

[mergify]

requeue

✅ This pull request will be re-embarked automatically

Details

The followup queue command will be automatically executed to re-embark the pull request

[mergify]

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at b8db3e4