Update Deneb to 1.4.0-beta.2 (devnet-9)#4735
Merged
michaelsproul merged 7 commits intosigp:deneb-free-blobsfrom Sep 25, 2023
Merged
Update Deneb to 1.4.0-beta.2 (devnet-9)#4735michaelsproul merged 7 commits intosigp:deneb-free-blobsfrom
michaelsproul merged 7 commits intosigp:deneb-free-blobsfrom
Conversation
Member
|
@dapplion I'm going to get this PR passing the tests and merge it 👍 |
michaelsproul
changed the title
Member
|
This is still WIP, I need to do some more massaging of the EF fork choice tests. |
michaelsproul
changed the title
Member
|
I've got the EF tests passing now. Ready for review |
michaelsproul
added
ready-for-review
ethDreamer
approved these changes
Sep 22, 2023
| config_name: None, | ||
| max_committees_per_slot: 4, | ||
| target_committee_size: 4, | ||
| min_per_epoch_churn_limit: 2, |
Member
There was a problem hiding this comment.
I was scratching my head for a while over this one, wondering why so many tests were failing on the new spec 😅
michaelsproul
added
ready-for-merge
jimmygchen
reviewed
Sep 25, 2023
realbigsean
added a commit
to realbigsean/lighthouse
that referenced
this pull request
Sep 25, 2023
This reverts commit 5c5afaf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
1.4.0-beta.2-hotfixAdditional Info