[Merged by Bors] - bors: require slasher and syncing sim tests#3645
Closed
michaelsproul wants to merge 2 commits intosigp:unstablefrom
Closed
[Merged by Bors] - bors: require slasher and syncing sim tests#3645michaelsproul wants to merge 2 commits intosigp:unstablefrom
michaelsproul wants to merge 2 commits intosigp:unstablefrom
Conversation
michaelsproul
added
ready-for-review
paulhauner
approved these changes
Oct 18, 2022
Member
paulhauner
left a comment
paulhauner
left a comment
There was a problem hiding this comment.
LGTM, nice catch!
I'm open about disallowed-from-async-lint, your call :)
michaelsproul
added
ready-for-merge
Member
Author
|
Yeah why not! Added it! |
paulhauner
approved these changes
Oct 19, 2022
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 19, 2022
## Issue Addressed I noticed that [this build](https://github.com/sigp/lighthouse/actions/runs/3269950873/jobs/5378036501) wasn't marked failed by Bors when the `syncing-simulator-ubuntu` job failed. This is because that job is absent from the `bors.toml` config. ## Proposed Changes Add missing jobs to Bors config so that they are required: - `syncing-simulator-ubuntu` - `slasher-tests` - `disallowed-from-async-lint` The `disallowed-from-async-lint` was previously allowed to fail because it was considered beta, but I think it's stable enough now we may as well require it.
bors
bot
changed the title
macladson
pushed a commit
to macladson/lighthouse
that referenced
this pull request
Jan 5, 2023
## Issue Addressed I noticed that [this build](https://github.com/sigp/lighthouse/actions/runs/3269950873/jobs/5378036501) wasn't marked failed by Bors when the `syncing-simulator-ubuntu` job failed. This is because that job is absent from the `bors.toml` config. ## Proposed Changes Add missing jobs to Bors config so that they are required: - `syncing-simulator-ubuntu` - `slasher-tests` - `disallowed-from-async-lint` The `disallowed-from-async-lint` was previously allowed to fail because it was considered beta, but I think it's stable enough now we may as well require it.
macladson
pushed a commit
to macladson/lighthouse
that referenced
this pull request
Jan 5, 2023
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed I noticed that [this build](https://github.com/sigp/lighthouse/actions/runs/3269950873/jobs/5378036501) wasn't marked failed by Bors when the `syncing-simulator-ubuntu` job failed. This is because that job is absent from the `bors.toml` config. ## Proposed Changes Add missing jobs to Bors config so that they are required: - `syncing-simulator-ubuntu` - `slasher-tests` - `disallowed-from-async-lint` The `disallowed-from-async-lint` was previously allowed to fail because it was considered beta, but I think it's stable enough now we may as well require it.
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
I noticed that this build wasn't marked failed by Bors when the
syncing-simulator-ubuntujob failed. This is because that job is absent from thebors.tomlconfig.Proposed Changes
Add missing jobs to Bors config so that they are required:
syncing-simulator-ubuntuslasher-testsdisallowed-from-async-lintThe
disallowed-from-async-lintwas previously allowed to fail because it was considered beta, but I think it's stable enough now we may as well require it.