[Merged by Bors] - beacon_node: add --disable-deposit-contract-sync flag#3597
Closed
pinkiebell wants to merge 4 commits intosigp:unstablefrom
Closed
[Merged by Bors] - beacon_node: add --disable-deposit-contract-sync flag#3597pinkiebell wants to merge 4 commits intosigp:unstablefrom
pinkiebell wants to merge 4 commits intosigp:unstablefrom
Conversation
|
|
Member
|
Heyo, thanks for the contribution. I'm open to the "disable-eth1-sync" flag, however we intentionally don't provide a "disable-backfill" flag since there's no protocol-level solution to storing blocks unless we have nodes that sync them. If all nodes were to run with this flag then we'd be at risk of losing those blocks forever. I know this is not ideal and it would be great to find a protocol-level solution, however until then I think forcing users to download them is the safest route. Would you be open to removing the backfill flag please? |
paulhauner
added
the
waiting-on-author
pinkiebell
changed the title
Contributor
Author
|
@paulhauner |
paulhauner
added
ready-for-review
michaelsproul
requested changes
Oct 17, 2022
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just a few minor points of feedback 🙏
michaelsproul
added
waiting-on-author
Overrides any previous option that enables the eth1 service.
pinkiebell
changed the title
michaelsproul
added
ready-for-merge
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 19, 2022
Overrides any previous option that enables the eth1 service. Useful for operating a `light` beacon node. Co-authored-by: Michael Sproul <micsproul@gmail.com>
bors
bot
changed the title
macladson
pushed a commit
to macladson/lighthouse
that referenced
this pull request
Jan 5, 2023
Overrides any previous option that enables the eth1 service. Useful for operating a `light` beacon node. Co-authored-by: Michael Sproul <micsproul@gmail.com>
macladson
pushed a commit
to macladson/lighthouse
that referenced
this pull request
Jan 5, 2023
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
Overrides any previous option that enables the eth1 service. Useful for operating a `light` beacon node. Co-authored-by: Michael Sproul <micsproul@gmail.com>
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overrides any previous option that enables the eth1 service.
Useful for operating a
lightbeacon node.