refactor(callgraph): Create resolution package and complete extraction package (PR #4) #375

shivasurya · 2025-11-15T21:52:04Z

Summary

Complete Phase 2 PR #4: AST Extraction Features by creating the resolution package and completing the extraction package. This PR migrates ~2000 LOC from 6 files into a clean hierarchical structure while maintaining full backward compatibility.

New Package Structure

resolution/ Package (1,127 lines)

Consolidates all resolution logic for imports, callsites, and type inference:

imports.go (297 lines) - Import extraction with relative import resolution (from .. import module)
callsites.go (271 lines) - Call site extraction with full argument tracking
inference.go (155 lines) - Type inference engine managing function scopes and variable bindings
return_type.go (404 lines) - Return type analysis and class instantiation resolution

extraction/ Package (961 lines)

Completes the extraction layer for Python AST analysis:

attributes.go (540 lines) - Class attribute extraction with type inference integration
variables.go (421 lines) - Variable assignment extraction and type tracking

Backward Compatibility

All original files updated with wrapper functions and type aliases:

// imports.go - Simple wrapper
func ExtractImports(...) (*core.ImportMap, error) {
    return resolution.ExtractImports(...)
}

// type_inference.go - Type aliases
type TypeInferenceEngine = resolution.TypeInferenceEngine
type FunctionScope = resolution.FunctionScope

Note: return_type.go contains documentation only (no wrapper) due to signature changes requiring direct migration to resolution package.

Test Migration

Moved 10 test files to new packages with full updates:

resolution/ (7 files): imports_test.go, imports_relative_test.go, callsites_test.go, inference_test.go, return_type_test.go, return_type_class_test.go
extraction/ (3 files): attributes_simple_test.go, attributes_coverage_test.go, variables_test.go

All test fixtures and relative paths adjusted for new locations.

Build Verification

✅ gradle buildGo - SUCCESS
✅ gradle testGo - ALL PASSING (100% pass rate)
✅ gradle lintGo - 0 issues

Files Changed (26 files, +2389/-2241 lines)

New Files

resolution/imports.go
resolution/callsites.go
resolution/inference.go
resolution/return_type.go
extraction/attributes.go
extraction/variables.go

Modified Files (Backward Compatibility)

imports.go → wrapper to resolution
callsites.go → wrapper to resolution
type_inference.go → type aliases to resolution
attribute_extraction.go → wrapper to extraction
variable_extraction.go → wrapper to extraction
return_type.go → documentation only
builder.go → updated all imports and calls

Test Migrations

7 tests moved to resolution/
3 tests moved to extraction/
1 test kept in parent (import cycle prevention)

Breaking Changes

None for most users. Direct imports of functions continue to work through wrappers.

Only breaking change: Code directly using ExtractReturnTypes or ResolveClassInstantiation must update to:

import "github.com/shivasurya/code-pathfinder/sourcecode-parser/graph/callgraph/resolution"

resolution.ExtractReturnTypes(...)
resolution.ResolveClassInstantiation(...)

Dependencies

Built on top of:

PR Added support for method query like interface #3 (refactor/03-stdlib-taint) - stdlib foundation
PR Parse full method name as identifier #2 (refactor/02-infrastructure-core) - core types
PR Tree-Sitter Implementation with Source Sink Analysis #1 (refactor/01-foundation-types) - base types

Codecov Report

❌ Patch coverage is 80.17621% with 180 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.23%. Comparing base (7ea3953) to head (e492089).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...de-parser/graph/callgraph/extraction/attributes.go	75.49%	49 Missing and 13 partials ⚠️
...ode-parser/graph/callgraph/extraction/variables.go	70.05%	44 Missing and 12 partials ⚠️
...e-parser/graph/callgraph/resolution/return_type.go	84.87%	23 Missing and 8 partials ⚠️
...ode-parser/graph/callgraph/resolution/callsites.go	86.58%	6 Missing and 5 partials ⚠️
...ecode-parser/graph/callgraph/resolution/imports.go	92.00%	4 Missing and 4 partials ⚠️
sourcecode-parser/graph/callgraph/builder.go	85.71%	4 Missing and 1 partial ⚠️
sourcecode-parser/graph/callgraph/callsites.go	0.00%	2 Missing ⚠️
sourcecode-parser/graph/callgraph/imports.go	0.00%	2 Missing ⚠️
...ode-parser/graph/callgraph/attribute_extraction.go	0.00%	1 Missing ⚠️
...ourcecode-parser/graph/callgraph/type_inference.go	50.00%	1 Missing ⚠️
... and 1 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   79.85%   78.23%   -1.63%     
==========================================
  Files          78       83       +5     
  Lines        6886     6914      +28     
==========================================
- Hits         5499     5409      -90     
- Misses       1157     1266     +109     
- Partials      230      239       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Improve test coverage for resolution/inference.go from 26% to >90%: ## New Test Coverage ### ResolveVariableType Function - Test variable type resolution from function returns - Test confidence decay calculation (1.0 * 0.8 * 0.95 = 0.76) - Test with different base confidence levels - Test with non-existent functions (returns nil) ### UpdateVariableBindingsWithFunctionReturns Function - Test resolving "call:funcName" placeholders - Test qualified function names (e.g., "logging.getLogger") - Test module-level scope resolution - Test function scope resolution with nested paths - Test unresolved function calls (remain as placeholders) - Test nil type handling (edge case, no panic) ## Test Scenarios Covered 1. **Simple name resolution**: call:create_user → myapp.controllers.create_user 2. **Qualified name resolution**: call:logging.getLogger → logging.getLogger 3. **Module-level scope**: No dots in FunctionFQN, append to module path 4. **Function scope**: Strip function name, add called function 5. **Non-existent returns**: Placeholder remains unchanged 6. **Nil type safety**: No panic on nil types ## Coverage Impact Before: 28 missing lines in inference.go (26.31% coverage) After: All critical paths covered (>90% coverage) This addresses the coverage gap reported in PR #375 review. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

shivasurya · 2025-11-15T22:16:57Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

shivasurya · 2025-11-16T00:00:55Z

Merge activity

Nov 16, 12:00 AM UTC: A user started a stack merge that includes this pull request via Graphite.
Nov 16, 12:05 AM UTC: Graphite rebased this pull request as part of a merge.
Nov 16, 12:06 AM UTC: @shivasurya merged this pull request with Graphite.

…n package Complete Phase 2 PR #4: AST Extraction Features (~2000 LOC migrated) ## New Packages Created ### resolution/ - imports.go (297 lines) - Import extraction and relative import resolution - callsites.go (271 lines) - Call site extraction with argument tracking - inference.go (155 lines) - Type inference engine with scope management - return_type.go (404 lines) - Return type analysis and class instantiation ### extraction/ - attributes.go (540 lines) - Class attribute extraction with type inference - variables.go (421 lines) - Variable assignment extraction and type tracking ## Backward Compatibility Created type aliases and wrapper functions in original files: - imports.go → calls resolution.ExtractImports - callsites.go → calls resolution.ExtractCallSites - type_inference.go → type aliases to resolution package - attribute_extraction.go → calls extraction.ExtractClassAttributes - variable_extraction.go → calls extraction.ExtractVariableAssignments - return_type.go → documentation only (signatures changed) ## Test Migration Moved 10 test files to new packages: - 7 tests to resolution/ (imports, callsites, inference, return_type) - 3 tests to extraction/ (attributes, variables) - Updated all imports and package declarations - Fixed type mismatches and relative paths - All tests passing with 100% success rate ## Build Verification - ✅ gradle buildGo - SUCCESS - ✅ gradle testGo - ALL PASSING - ✅ gradle lintGo - 0 issues Related to PR #4 specification document 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Improve test coverage for resolution/inference.go from 26% to >90%: ## New Test Coverage ### ResolveVariableType Function - Test variable type resolution from function returns - Test confidence decay calculation (1.0 * 0.8 * 0.95 = 0.76) - Test with different base confidence levels - Test with non-existent functions (returns nil) ### UpdateVariableBindingsWithFunctionReturns Function - Test resolving "call:funcName" placeholders - Test qualified function names (e.g., "logging.getLogger") - Test module-level scope resolution - Test function scope resolution with nested paths - Test unresolved function calls (remain as placeholders) - Test nil type handling (edge case, no panic) ## Test Scenarios Covered 1. **Simple name resolution**: call:create_user → myapp.controllers.create_user 2. **Qualified name resolution**: call:logging.getLogger → logging.getLogger 3. **Module-level scope**: No dots in FunctionFQN, append to module path 4. **Function scope**: Strip function name, add called function 5. **Non-existent returns**: Placeholder remains unchanged 6. **Nil type safety**: No panic on nil types ## Coverage Impact Before: 28 missing lines in inference.go (26.31% coverage) After: All critical paths covered (>90% coverage) This addresses the coverage gap reported in PR #375 review. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

This was referenced Nov 15, 2025

refactor: create core package with foundation types #372

Merged

refactor: create registry, cfg, and resolution packages #373

Merged

This was referenced Nov 15, 2025

refactor(callgraph): Create analysis/taint, extraction packages and complete registry #374

Merged

refactor(callgraph): Move advanced resolution to resolution package (PR #5) #376

Merged

shivasurya self-assigned this Nov 15, 2025

shivasurya added enhancement New feature or request go Pull requests that update go code refactor labels Nov 15, 2025

This was referenced Nov 15, 2025

refactor: Create patterns package for pattern detection (PR #6) #377

Merged

refactor: Extract builder logic to builder/ package (#7) #378

Merged

shivasurya changed the base branch from refactor/03-stdlib-taint to graphite-base/375 November 16, 2025 00:03

shivasurya changed the base branch from graphite-base/375 to main November 16, 2025 00:04

shivasurya and others added 2 commits November 16, 2025 00:05

shivasurya force-pushed the refactor/04-ast-extraction branch from c36b4d1 to e492089 Compare November 16, 2025 00:05

shivasurya merged commit 480d8ff into main Nov 16, 2025
3 checks passed

shivasurya deleted the refactor/04-ast-extraction branch November 16, 2025 00:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(callgraph): Create resolution package and complete extraction package (PR #4) #375

refactor(callgraph): Create resolution package and complete extraction package (PR #4) #375

Uh oh!

shivasurya commented Nov 15, 2025

Uh oh!

safedep bot commented Nov 15, 2025 •

edited

Loading

Uh oh!

codecov bot commented Nov 15, 2025 •

edited

Loading

Uh oh!

shivasurya commented Nov 15, 2025 •

edited

Loading

Uh oh!

shivasurya commented Nov 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

refactor(callgraph): Create resolution package and complete extraction package (PR #4) #375

refactor(callgraph): Create resolution package and complete extraction package (PR #4) #375

Uh oh!

Conversation

shivasurya commented Nov 15, 2025

Summary

New Package Structure

resolution/ Package (1,127 lines)

extraction/ Package (961 lines)

Backward Compatibility

Test Migration

Build Verification

Files Changed (26 files, +2389/-2241 lines)

New Files

Modified Files (Backward Compatibility)

Test Migrations

Breaking Changes

Dependencies

Related

Uh oh!

safedep bot commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SafeDep Report Summary

Uh oh!

codecov bot commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shivasurya commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shivasurya commented Nov 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

safedep bot commented Nov 15, 2025 •

edited

Loading

codecov bot commented Nov 15, 2025 •

edited

Loading

shivasurya commented Nov 15, 2025 •

edited

Loading

shivasurya commented Nov 16, 2025 •

edited

Loading