refactor: create core package with foundation types

[shivasurya]

Overview

This PR creates the foundational type system for the callgraph refactoring by extracting pure data structures with zero internal dependencies into a new core package. These types form the contract that all other packages will depend on.

Status: ✅ Ready for review
Estimated Effort: 2-3 days
Risk Level: ⬜ Low (pure types, no logic changes)

Changes

New Core Package Structure

sourcecode-parser/graph/callgraph/core/
├── types.go              # CallGraph, CallSite, Location, Argument, ModuleRegistry, ImportMap
├── statement.go          # Statement, DefUseChain, DefUseStats  
├── taint_summary.go      # TaintInfo, TaintSummary
├── frameworks.go         # FrameworkDefinition, IsKnownFramework
├── attribute_types.go    # ClassAttribute, ClassAttributes, TypeInfo
├── stdlib_types.go       # StdlibRegistry + all related types and methods
├── doc.go               # Package documentation
├── types_test.go        # Moved and updated tests
├── statement_test.go    # Moved and updated tests
├── taint_summary_test.go # Moved and updated tests
└── frameworks_test.go    # Moved and updated tests

Type Aliases for Backward Compatibility

All original files updated with type aliases and deprecation notices:

• types.go - Aliased CallGraph, CallSite, Location, etc.
• statement.go - Aliased Statement, DefUseChain, DefUseStats
• taint_summary.go - Aliased TaintInfo, TaintSummary
• frameworks.go - Aliased FrameworkDefinition
• attribute_registry.go - Aliased ClassAttribute, ClassAttributes
• stdlib_registry.go - Aliased all stdlib types
• type_inference.go - Aliased TypeInfo

Test Results

✅ Build: gradle buildGo - SUCCESSFUL
✅ Tests: gradle testGo - ALL PASSING
✅ Lint: gradle lintGo - 0 ISSUES
✅ Coverage: callgraph 87.3%, core 74.1%

Key Features

• Zero breaking changes - Type aliases ensure existing code works without modification
• Pure data structures - Core package has minimal dependencies
• Clean separation - Foundation types isolated from business logic
• Full test coverage - All existing tests pass

Related

• Part of callgraph refactoring stack (PR Tree-Sitter Implementation with Source Sink Analysis #1 of 8)
• Spec: pr-01-foundation-types.md
• Parent Issue: Callgraph directory refactoring

Checklist

• Tests passing (gradle testGo)
• Lint passing (gradle lintGo)
• Type aliases added for backward compatibility
• Tests moved and updated to core/ package
• Package documentation added
• No breaking changes

🤖 Generated with Claude Code

Co-Authored-By: Claude [email protected]

[shivasurya]

• refactor: Extract builder logic to builder/ package (#7) #378
• refactor: Create patterns package for pattern detection (PR #6) #377
• refactor(callgraph): Move advanced resolution to resolution package (PR #5) #376
• refactor(callgraph): Create resolution package and complete extraction package (PR #4) #375
• refactor(callgraph): Create analysis/taint, extraction packages and complete registry #374
• refactor: create registry, cfg, and resolution packages #373
• refactor: create core package with foundation types #372 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[safedep]

SafeDep Report Summary

No dependency changes detected. Nothing to scan.

_{This report is generated by SafeDep Github App}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.07%. Comparing base (7fec4ce) to head (7a38aa9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
+ Coverage   79.81%   80.07%   +0.26%     
==========================================
  Files          64       69       +5     
  Lines        6802     6836      +34     
==========================================
+ Hits         5429     5474      +45     
+ Misses       1147     1139       -8     
+ Partials      226      223       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[shivasurya]

✅ Coverage Improvement

Updated the PR to address the coverage concerns:

Before

• Core package: 74.1% coverage
• Missing coverage in:
  • statement.go: BuildDefUseChains (0%), ComputeStats (0%)
  • stdlib_types.go: All methods (0%)

After

• Core package: 100.0% coverage ✨

Changes

• Added comprehensive tests for BuildDefUseChains with 4 test scenarios
• Added comprehensive tests for ComputeStats with 4 test scenarios
• Created stdlib_types_test.go with full coverage of all StdlibRegistry methods
• All 394 new test lines added

Test Results

ok  	.../graph/callgraph/core	0.315s	coverage: 100.0% of statements

The patch coverage should now be significantly improved!

[shivasurya]

Merge activity

• Nov 16, 12:00 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Nov 16, 12:01 AM UTC: @shivasurya merged this pull request with Graphite.