Pr/fix init error #127
Merged
Pr/fix init error #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When findUp can't find an existing package-scripts.js file, it returns null, which is passed back to findUp and throws an error because path.resolve can only accept strings as arguments sezna#124
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 286 286
=====================================
Hits 286 286
Continue to review full report at Codecov.
|
kentcdodds
requested changes
Mar 21, 2017
Collaborator
kentcdodds
left a comment
kentcdodds
left a comment
There was a problem hiding this comment.
Just a small fix to the contributors table :)
.all-contributorsrc
Outdated
| "name": "Nate Cavanaugh", | ||
| "avatar_url": "https://avatars1.githubusercontent.com/u/116871?v=3", | ||
| "profile": "http://alterform.com", | ||
| "contributions": [] |
Collaborator
There was a problem hiding this comment.
Could you add "code" to this array and then run npm start generateContributors?
Contributor
Author
There was a problem hiding this comment.
Done, thanks for the heads up :)
Collaborator
|
This is great, thank you! |
The contributions array in .all-contributorsrc was missing the "code" value
kentcdodds
approved these changes
Mar 21, 2017
Collaborator
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When findUp can't find an existing package-scripts.js file, it returns null, which is passed back to
findUp and throws an error because path.resolve can only accept strings as arguments
#124
What: Fixes error thrown when a package-scripts.js file doesn't exist while running
initWhy: Because if you're running
nps initwithout an existing package-scripts.js file, it won't work, forcing developers to have to create the file manually.How: Checking that the
pathreturned fromgetPSConfigFilepathis actually a string before passing it tofindUp.sync.I tried figuring out why the tests never fail for this, but I believe it's because of jest's mocking of findUp means that it never even hits the
path.resolvemethod, so I'm not sure how you'd want to test for this particular case.