init command fails with a null path TypeError

[wopian]

• nps version: 5.0.4
• node version: 7.2.1
• npm version: 4.1.2

package.json:

"scripts": {
    "dev": "node build/dev-server.js",
    "build": "node build/build.js",
    "test": "cross-env BABEL_ENV=test karma start test/unit/karma.conf.js --single-run",
    "lint": "eslint --ext .js,.vue client test/unit/specs"
  },

The command executed:

./node_modules/.bin/nps init --type yml

The output:

path.js:7
    throw new TypeError('Path must be a string. Received ' + inspect(path));
    ^

TypeError: Path must be a string. Received null
    at assertPath (path.js:7:11)
    at Object.resolve (path.js:186:7)
    at Function.module.exports.sync (C:\github\hibari\node_modules\locate-path\index.js:20:28)
    at Function.module.exports.sync (C:\github\hibari\node_modules\nps\node_modules\find-up\index.js:38:27)
    at Object.onInit [as handler] (C:\github\hibari\node_modules\nps\dist\bin-utils\parser.js:155:49)
    at Object.self.runCommand (C:\github\hibari\node_modules\nps\node_modules\yargs\lib\command.js:170:22)
    at parseArgs (C:\github\hibari\node_modules\nps\node_modules\yargs\yargs.js:920:28)
    at Object.Yargs.self.parse (C:\github\hibari\node_modules\nps\node_modules\yargs\yargs.js:499:18)
    at parse (C:\github\hibari\node_modules\nps\dist\bin-utils\parser.js:85:27)
    at Object.<anonymous> (C:\github\hibari\node_modules\nps\dist\bin\nps.js:22:33)

Problem description:

Running the initialisation script to generate and update package.json automatically fails with the above error with the 4 scripts I currently have.

Repo

[kentcdodds]

Thanks for the report. I'll get to it when I can. Anyone wanna dig in a bit?

[wopian]

Further note: windows 10 and with VSCode 1.10's terminal. Happens when generating as JS or as YAML.

Same scripts written in package-scripts.yml function just fine with "start": "nps" in package.json:

scripts:
  dev:
    script: node build/dev-server.js
    description: run server and watch for changes
  build:
    default:
      script: node build/build.js
      description: build from source code
    report:
      script: node build/build.js --report
      description: build from source code & generate a report on file size
  test:
    script: cross-env BABEL_ENV=test karma start test/unit/karma.conf.js --single-run
    description: run tests with karma
  lint:
    script: eslint --ext .js,.vue client test/unit/specs
    description: lint files with eslint

[natecavanaugh]

@kentcdodds
I'm running into this too, and from what I can tell from my quick investigation is that it only happens when you don't already have a package-scripts.js file and it's these two lines.
Basically, the getPSConfigFilepath function is returning null if the file doesn't exist, and the find-up module in the second call is getting passed that null (which trickles all the way down to Node's path.resolve, which can only accept a string).

Maybe changing this line to being:

var fileExists = path && Boolean(findUp.sync(path))

?

Anyways, I hope that helps narrow it down :)

[kentcdodds]

Thanks @natecavanaugh, I've also reproduced this issue. Anyone wanna tackle it? It should be pretty straightforward!

[natecavanaugh]

I can go ahead and shoot one over, it shouldn't be too bad :)