Add seed parameter to turbo tests #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 11, 2023 14:16
1. When seed is not sent 2. With response status in cli being 0 even when failures appeared
ilyazub
reviewed
May 26, 2023
Collaborator
ilyazub
left a comment
ilyazub
left a comment
There was a problem hiding this comment.
Thanks, @mRudzki! I'll review your PR and share my feedback.
P.S. Interestingly, Discourse also introduced a similar change recently: discourse/discourse#21598
Co-authored-by: Illia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the reproducibility by allowing the user to define seeds. It can show randomly failing specs (I have had some project that had problem with those) failing only with specific seed.