Skip to content

Conversation

@ilyazub
Copy link
Collaborator

@ilyazub ilyazub commented Jan 17, 2024

Fixes #56
Resolves #40
Resolves #57

Changes

Changes
* Remove the default `seed` value (ref: #33)
* Use exit status from RSpec calls (ref: #20)
@ilyazub ilyazub self-assigned this Jan 17, 2024
@ilyazub ilyazub force-pushed the remove-default-seed branch from 03a879f to 84f2487 Compare June 4, 2024 15:19
@ilyazub ilyazub marked this pull request as ready for review June 4, 2024 15:36
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that TurboTests::Reporter almost entirely duplicates RSpec::Core::Reporter. I'll try to inherit RSpec::Core::Reporter or do something similar to avoid duplication.

end
when "message"
@reporter.message(message[:message])
if message[:message].include?("An error occurred") || message[:message].include?("occurred outside of examples")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruby 3.3 didn't output `NilClass` in `undefined method `[]' for nil` message

Ref: https://github.com/serpapi/turbo_tests/actions/runs/9370241051/job/25796715330
@ilyazub ilyazub requested a review from Freaky June 6, 2024 15:39
@ilyazub ilyazub merged commit aeae4ff into master Jun 18, 2024
@ilyazub ilyazub deleted the remove-default-seed branch June 18, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Seed option is not passed to underlying rspec runners turbo_tests output missed one error compared and failed lines (compared to RSpec output)

2 participants