Skip to content

Conversation

@semuadmin
Copy link
Contributor

pyubx2 Pull Request Template

Description

CHANGES:

  1. Inherit SocketWrapper from pynmeagps.
  2. Update minimum pynmeagps version to 1.0.50 (adds GPFMI support).
  3. Add status decodes for ESF-ALG.

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

If you're adding new UBX message definitions for Generation 9+ devices, please check for any corresponding configuration database updates (ubxtypes_configdb.py).

  • Test A
  • Test B

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.MD).
  • I have performed a self-review of my own code.
  • (if appropriate) I have cited my u-blox documentation source(s).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added the enhancement New feature or request label May 6, 2025
@semuadmin semuadmin added this to the RC 1.2.52 milestone May 6, 2025
@semuadmin semuadmin requested a review from a team May 6, 2025 08:03
@semuadmin semuadmin self-assigned this May 6, 2025
@semuadmin semuadmin marked this pull request as draft May 6, 2025 08:03
@semuadmin semuadmin marked this pull request as ready for review May 6, 2025 08:11
@semuadmin semuadmin merged commit 9e72e37 into master May 6, 2025
@semuadmin semuadmin deleted the RC-1.2.52 branch May 6, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants