Skip to content

download_demo failing when output_folder_path is set #2697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2025
Merged

download_demo failing when output_folder_path is set #2697

merged 2 commits into from
Oct 6, 2025

Conversation

@fealho
Copy link
Member

@fealho fealho commented Oct 3, 2025

CU-86b6xnx26, Resolve #2687.

@sdv-team
Copy link
Contributor

sdv-team commented Oct 3, 2025

Task linked: CU-86b6xnx26 SDV - download_demo failing when output_folder_path is set #2687

@fealho fealho marked this pull request as ready for review October 3, 2025 16:55
@fealho fealho requested a review from a team as a code owner October 3, 2025 16:55
@fealho fealho requested review from gsheni and removed request for a team October 3, 2025 16:55
@fealho fealho requested a review from rwedge October 3, 2025 16:55
@codecov
Copy link

codecov bot commented Oct 3, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.10%. Comparing base (2b20aa4) to head (9fd073c).

Additional details and impacted files 
@@                       Coverage Diff                        @@
##           feature-branch-download-demo    #2697      +/-   ##
================================================================
+ Coverage                         96.76%   98.10%   +1.34%     
================================================================
  Files                                70       70              
  Lines                              7608     7619      +11     
================================================================
+ Hits                               7362     7475     +113     
+ Misses                              246      144     -102
Flag Coverage Δ
integration 76.11% <80.95%> (?)
unit 96.79% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sdv-team
Copy link
Contributor

sdv-team commented Oct 3, 2025

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

rwedge
rwedge reviewed Oct 3, 2025
View reviewed changes
@fealho fealho force-pushed the issue-2687-download-demo-output-folder branch from 8eea62c to 9fd073c Compare October 4, 2025 21:03
@sdv-team
Copy link
Contributor

sdv-team commented Oct 4, 2025

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@fealho fealho requested a review from rwedge October 6, 2025 14:12
@fealho fealho force-pushed the feature-branch-download-demo branch from 2b20aa4 to ca061ea Compare October 6, 2025 14:18
fealho added 2 commits October 6, 2025 08:13
@fealho
Store metadata when downloading
eaaac5e 
Update the download_demo and get_available_demos functions (#2669)

Add test

Fix rebase
@fealho
Fix download_demo error when the dataset_name in the metainfo does no…
62ee13b 
…t match the dataset name in the folder (#2695)
@fealho fealho force-pushed the issue-2687-download-demo-output-folder branch from c3bdfa2 to 62ee13b Compare October 6, 2025 15:14
@sdv-team
Copy link
Contributor

sdv-team commented Oct 6, 2025

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@fealho fealho merged commit 6ce265a into feature-branch-download-demo Oct 6, 2025
47 checks passed
@fealho fealho deleted the issue-2687-download-demo-output-folder branch October 6, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwedge rwedge rwedge approved these changes

@gsheni gsheni gsheni approved these changes

Assignees

@fealho fealho

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fealho @sdv-team @rwedge @gsheni